Bug 86728 – [EFL][DRT] Gardening failure test cases.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Krzysztof Czech]

Removing tests related to editing callbacks functionality from Skipped list.
Adding new bugs regarding drag'n'drop and spell checking. Merging tests with particular bugs.

[Krzysztof Czech]

Created attachment 142468 [details]
Gardening failure test cases

[WebKit Review Bot]

Attachment 142468 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/efl/test_expectations.txt:115:  Missing expectations BUGWK84338 : fast/forms/textarea-paste-newline.html  [test/expectations] [5]
LayoutTests/platform/efl/test_expectations.txt:541:  Missing expectations BUGWK86623 : editing/pasteboard/subframe-dragndrop-1.html  [test/expectations] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Krzysztof Czech]

Created attachment 142471 [details]
Gardening failure test cases.

[WebKit Review Bot]

Comment on attachment 142471 [details]
Gardening failure test cases.

Clearing flags on attachment: 142471

Committed r117449: <http://trac.webkit.org/changeset/117449>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Krzysztof Czech]

Created attachment 142478 [details]
Gardening failure test cases.

[Raphael Kubo da Costa (:rakuco)]

I've already landed the second patch in this bug, so your third one will probably conflict when applying. Please file another report with the remaining gardening.

[Raphael Kubo da Costa (:rakuco)]

Reverted r117449 for reason:

Broke many unskipped tests which lack expectations

Committed r117461: <http://trac.webkit.org/changeset/117461>

[Raphael Kubo da Costa (:rakuco)]

I've reverted r117449 -- it caused a lot of tests to fail, as described in bug 86753.

[Krzysztof Czech]

Created attachment 142713 [details]
Gardening failure test cases - corrected Skipped tests with lack of expectations.

[WebKit Review Bot]

Comment on attachment 142713 [details]
Gardening failure test cases - corrected Skipped tests with lack of expectations.

Rejecting attachment 142713 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 #11 succeeded at 1587 (offset -9 lines).
Hunk #12 succeeded at 1612 (offset -9 lines).
Hunk #13 succeeded at 1656 (offset -9 lines).
Hunk #14 succeeded at 1665 (offset -9 lines).
patching file LayoutTests/platform/efl/test_expectations.txt
Hunk #2 FAILED at 524.
1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/efl/test_expectations.txt.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12723670

[Krzysztof Czech]

Created attachment 142720 [details]
Gardening failure test cases - corrected Skipped tests with lack of expectations.

[WebKit Review Bot]

Attachment 142720 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/efl/test_expectations.txt:531:  Missing expectations BUGWK86615 : editing/deleting/5408255.html  [test/expectations] [5]
LayoutTests/platform/efl/test_expectations.txt:532:  Missing expectations BUGWK86615 : editing/deleting/regional-indicators.html  [test/expectations] [5]
LayoutTests/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 142720 [details]
Gardening failure test cases - corrected Skipped tests with lack of expectations.

Please fix the style issues, they are valid.

[Krzysztof Czech]

Created attachment 142722 [details]
Gardening failure test cases - corrected Skipped tests with lack of expectations.

[WebKit Review Bot]

Comment on attachment 142722 [details]
Gardening failure test cases - corrected Skipped tests with lack of expectations.

Clearing flags on attachment: 142722

Committed r117597: <http://trac.webkit.org/changeset/117597>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.