Some test images at the above URL are PNG_COLOR_TYPE_PALETTE color and have an ICC color profile. The public image decoders that support ICC color profiles (currently, Chromium MAC) decode the images fine but fail to properly color correct the decoded image. Add a test for this case, then fix it later by adding PNG_COLOR_TYPE_PALETTE color correction support to the public PNG decoder.
These paletted images should be color corrected but are not: http://www.libpng.org/pub/png/img_png/ArcTriomphe-iCCP-red-green-swap.png http://www.libpng.org/pub/png/img_png/ArcTriomphe-iCCP-red-blue-swap.png
Reference image (what they should look it): http://www.libpng.org/pub/png/img_png/ArcTriomphe-iCCP-orig.png
Created attachment 142631 [details] Screen shot: Safari-5.1.5-left and Chrome-20.0.1132.3-dev-right
Safari gets it right, and so does Mozilla 3.6+
The images on the URL page are Creative Commons Attribution-NonCommercial 2.5 License. http://creativecommons.org/licenses/by-nc/2.5 I wrote to the page owner asking for permission to use the images. Reply attached.
Created attachment 142664 [details] png-colortest-html-images-webkit-test-use.txt
+brian per comment #5 #6, ok to use of these images in your view?
I took the photo and created the images from scratch. Consider them licensed under CC-SA or an equivalent "use as you wish but share any modifications/derivations under the same terms" license. And if that doesn't cut it, let me know.
Thank you Greg. WebKit is BSD licensed http://trac.webkit.org/browser/trunk/Source/WebKit/LICENSE and Brian would know if what you've said "cuts it" for us. I'll prepare a layout test patch, awaiting word on ok to use.
Created attachment 143482 [details] Patch
Comment on attachment 143482 [details] Patch LGTM, assuming you're happy with the licensing terms.
Created attachment 145939 [details] paletted-color-gamma-one-color-profile-image-info Ah well, no answers: created a paletted PNG image in photoshop with a gamma-1.0 RGB color profile for this test. Image and profile details in the attachment.
Created attachment 145940 [details] test image in chrome 21, safari 5.1.7, firefox 12 Chrome clearly does not color correct this image.
Created attachment 145941 [details] Patch
Comment on attachment 145941 [details] Patch Clearing flags on attachment: 145941 Committed r119664: <http://trac.webkit.org/changeset/119664>
All reviewed patches have been landed. Closing bug.