WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
86718
Web Inspector: HeapSnapshot: speed-up calculateObjectToWindowDistance
https://bugs.webkit.org/show_bug.cgi?id=86718
Summary
Web Inspector: HeapSnapshot: speed-up calculateObjectToWindowDistance
Ilya Tikhonovsky
Reported
2012-05-17 04:23:15 PDT
The idea is to switch from nodeIndex2distance array to nodeOrdinal2distance external array. Due to nature of nodeIndex values the original array was sparsed. RESULT heap-snapshot: _calculateObjectToWindowDistance= 768 ms vs RESULT heap-snapshot: _calculateObjectToWindowDistance= 110 ms
Attachments
Patch
(6.41 KB, patch)
2012-05-17 04:25 PDT
,
Ilya Tikhonovsky
yurys
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1
2012-05-17 04:25:12 PDT
Created
attachment 142451
[details]
Patch
Yury Semikhatsky
Comment 2
2012-05-17 04:48:21 PDT
Comment on
attachment 142451
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=142451&action=review
> Source/WebCore/inspector/front-end/HeapSnapshot.js:942 > + ? nodes[nodeIndex + firstEdgeIndexOffset + nodeFieldCount]
Please revert change in this line.
Ilya Tikhonovsky
Comment 3
2012-05-17 05:47:23 PDT
Committed
r117437
: <
http://trac.webkit.org/changeset/117437
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug