Bug 86718 - Web Inspector: HeapSnapshot: speed-up calculateObjectToWindowDistance
Summary: Web Inspector: HeapSnapshot: speed-up calculateObjectToWindowDistance
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-17 04:23 PDT by Ilya Tikhonovsky
Modified: 2012-05-17 05:47 PDT (History)
10 users (show)

See Also:


Attachments
Patch (6.41 KB, patch)
2012-05-17 04:25 PDT, Ilya Tikhonovsky
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-05-17 04:23:15 PDT
The idea is to switch from nodeIndex2distance array to nodeOrdinal2distance external array.
Due to nature of nodeIndex values the original array was sparsed.

RESULT heap-snapshot: _calculateObjectToWindowDistance= 768 ms
vs
RESULT heap-snapshot: _calculateObjectToWindowDistance= 110 ms
Comment 1 Ilya Tikhonovsky 2012-05-17 04:25:12 PDT
Created attachment 142451 [details]
Patch
Comment 2 Yury Semikhatsky 2012-05-17 04:48:21 PDT
Comment on attachment 142451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142451&action=review

> Source/WebCore/inspector/front-end/HeapSnapshot.js:942
> +                         ? nodes[nodeIndex + firstEdgeIndexOffset + nodeFieldCount]

Please revert change in this line.
Comment 3 Ilya Tikhonovsky 2012-05-17 05:47:23 PDT
Committed r117437: <http://trac.webkit.org/changeset/117437>