Bug 86714 - [Worker] Web Worker lacks test to check the name attribute of SharedWorker
Summary: [Worker] Web Worker lacks test to check the name attribute of SharedWorker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-17 00:35 PDT by Li Yin
Modified: 2012-05-17 01:05 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.40 KB, patch)
2012-05-17 00:42 PDT, Li Yin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Li Yin 2012-05-17 00:35:50 PDT 
Spec: http://www.w3.org/TR/2012/CR-workers-20120501/#sharedworkerglobalscope

The name attribute must return the value it was assigned when the SharedWorkerGlobalScope object was created.

So we should have a test to check it, there is a test "fast/worker/shared-worker-name.html" already, but it doesn't cover this.
I will improve the test to do that.
Comment 1 Li Yin 2012-05-17 00:42:11 PDT 
Created attachment 142432 [details]
Patch
Comment 2 Kentaro Hara 2012-05-17 00:52:08 PDT 
Comment on attachment 142432 [details]
Patch

Thanks for improving the test coverage!
Comment 3 WebKit Review Bot 2012-05-17 01:05:55 PDT 
Comment on attachment 142432 [details]
Patch

Clearing flags on attachment: 142432

Committed r117411: <http://trac.webkit.org/changeset/117411>
Comment 4 WebKit Review Bot 2012-05-17 01:05:59 PDT 
All reviewed patches have been landed.  Closing bug.