Bug 86711 - Web Inspector: Hover on a breakpoint in breakpoint-pane does not get differentiated.
Summary: Web Inspector: Hover on a breakpoint in breakpoint-pane does not get differen...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-16 23:50 PDT by sam
Modified: 2012-05-17 06:53 PDT (History)
11 users (show)

See Also:

Attachments
screen shot hovering effect on breakpoints in Breakpoints pane. (60.84 KB, image/png)
2012-05-16 23:50 PDT, sam 		no flags Details
Patch (1.17 KB, patch)
2012-05-17 00:09 PDT, sam 		no flags Details | Formatted Diff | Diff
Patch (1.17 KB, patch)
2012-05-17 03:18 PDT, sam 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description sam 2012-05-16 23:50:18 PDT 
Created attachment 142423 [details]
screen shot hovering effect on breakpoints in Breakpoints pane.

Hover on a breakpoint in Breakpoints-pane does not get differentiated with other breakpoints in list.
Have attached the screen shot with some options. Will upload the patch.
Comment 1 sam 2012-05-17 00:09:28 PDT 
Created attachment 142428 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-17 00:12:01 PDT 
Attachment 142428 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 sam 2012-05-17 03:18:46 PDT 
Created attachment 142447 [details]
Patch
Comment 4 sam 2012-05-17 04:03:35 PDT 
(In reply to comment #3)
> Created an attachment (id=142447) [details]
> Patch

The patch is for option 2 from the attachment(screen shot) in Description. Is it ok?
Comment 5 Yury Semikhatsky 2012-05-17 06:36:30 PDT 
Comment on attachment 142447 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142447&action=review

> Source/WebCore/inspector/front-end/inspector.css:2150
> +    background-color: rgba(56, 121, 217, 0.2);

Is alpha channel 0.1(which matches elements tree selection) too blind ?
Comment 6 sam 2012-05-17 06:40:03 PDT 
(In reply to comment #5)
> (From update of attachment 142447 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142447&action=review
> 
> > Source/WebCore/inspector/front-end/inspector.css:2150
> > +    background-color: rgba(56, 121, 217, 0.2);
> 
> Is alpha channel 0.1(which matches elements tree selection) too blind ?

Ya i tried that, but was coming out too blind.
Comment 7 WebKit Review Bot 2012-05-17 06:53:37 PDT 
Comment on attachment 142447 [details]
Patch

Clearing flags on attachment: 142447

Committed r117445: <http://trac.webkit.org/changeset/117445>
Comment 8 WebKit Review Bot 2012-05-17 06:53:55 PDT 
All reviewed patches have been landed.  Closing bug.