RESOLVED FIXED 86711
Web Inspector: Hover on a breakpoint in breakpoint-pane does not get differentiated.
https://bugs.webkit.org/show_bug.cgi?id=86711
Summary Web Inspector: Hover on a breakpoint in breakpoint-pane does not get differen...
sam
Reported 2012-05-16 23:50:18 PDT
Created attachment 142423 [details] screen shot hovering effect on breakpoints in Breakpoints pane. Hover on a breakpoint in Breakpoints-pane does not get differentiated with other breakpoints in list. Have attached the screen shot with some options. Will upload the patch.
Attachments
screen shot hovering effect on breakpoints in Breakpoints pane. (60.84 KB, image/png)
2012-05-16 23:50 PDT, sam
no flags
Patch (1.17 KB, patch)
2012-05-17 00:09 PDT, sam
no flags
Patch (1.17 KB, patch)
2012-05-17 03:18 PDT, sam
no flags
sam
Comment 1 2012-05-17 00:09:28 PDT
WebKit Review Bot
Comment 2 2012-05-17 00:12:01 PDT
Attachment 142428 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
sam
Comment 3 2012-05-17 03:18:46 PDT
sam
Comment 4 2012-05-17 04:03:35 PDT
(In reply to comment #3) > Created an attachment (id=142447) [details] > Patch The patch is for option 2 from the attachment(screen shot) in Description. Is it ok?
Yury Semikhatsky
Comment 5 2012-05-17 06:36:30 PDT
Comment on attachment 142447 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142447&action=review > Source/WebCore/inspector/front-end/inspector.css:2150 > + background-color: rgba(56, 121, 217, 0.2); Is alpha channel 0.1(which matches elements tree selection) too blind ?
sam
Comment 6 2012-05-17 06:40:03 PDT
(In reply to comment #5) > (From update of attachment 142447 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=142447&action=review > > > Source/WebCore/inspector/front-end/inspector.css:2150 > > + background-color: rgba(56, 121, 217, 0.2); > > Is alpha channel 0.1(which matches elements tree selection) too blind ? Ya i tried that, but was coming out too blind.
WebKit Review Bot
Comment 7 2012-05-17 06:53:37 PDT
Comment on attachment 142447 [details] Patch Clearing flags on attachment: 142447 Committed r117445: <http://trac.webkit.org/changeset/117445>
WebKit Review Bot
Comment 8 2012-05-17 06:53:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.