Bug 86702 - This is not a joke: 3.7X speedup from removing a call to sleep
Summary: This is not a joke: 3.7X speedup from removing a call to sleep
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-16 20:46 PDT by Geoffrey Garen
Modified: 2012-09-04 15:17 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.53 KB, patch)
2012-05-16 20:53 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (2.61 KB, patch)
2012-05-16 21:31 PDT, Geoffrey Garen 		eric: review+
Details | Formatted Diff | Diff
The GC benchmark (for posterity) (1.56 KB, text/html)
2012-09-04 15:16 PDT, Geoffrey Garen 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2012-05-16 20:46:04 PDT 
This is not a joke: 3.7X speedup from removing a call to sleep
Comment 1 Geoffrey Garen 2012-05-16 20:53:40 PDT 
Created attachment 142407 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-16 20:57:31 PDT 
Attachment 142407 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/TC..." exit_code: 1
Source/WTF/wtf/TCSpinLock.h:132:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2012-05-16 21:31:13 PDT 
Created attachment 142409 [details]
Patch
Comment 4 WebKit Review Bot 2012-05-16 21:33:07 PDT 
Attachment 142409 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/TC..." exit_code: 1
Source/WTF/wtf/TCSpinLock.h:132:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Eric Seidel (no email) 2012-05-17 03:31:06 PDT 
Entertaining. :)
Comment 6 Eric Seidel (no email) 2012-05-17 03:33:36 PDT 
Comment on attachment 142409 [details]
Patch

I should note this is from the original tcmalloc import: http://trac.webkit.org/changeset/10634
Comment 7 Geoffrey Garen 2012-05-17 12:07:12 PDT 
Committed r117478: <http://trac.webkit.org/changeset/117478>
Comment 8 Geoffrey Garen 2012-09-04 15:16:41 PDT 
Created attachment 162108 [details]
The GC benchmark (for posterity)
Comment 9 Geoffrey Garen 2012-09-04 15:17:24 PDT 
Uploading a version of the benchmark I was using, so other folks can play with it.