Bug 86686 – Crash if SVG gradient stop has display: none set

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Tim Horton]

We crash if an otherwise-valid SVG gradient stop has display: none set, because there is no renderer created, but we depend on it having been created.

I have a patch.

<rdar://problem/10751905>

[Tim Horton]

Created attachment 142362 [details]
patch

[Dean Jackson]

Comment on attachment 142362 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142362&action=review

> LayoutTests/ChangeLog:5
> +        <rdar://problem/10751905>

I don't *think* we typically include the radar link in ChangeLogs.

[Alexey Proskuryakov]

Comment on attachment 142362 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142362&action=review

>> LayoutTests/ChangeLog:5
>> +        <rdar://problem/10751905>
> 
> I don't *think* we typically include the radar link in ChangeLogs.

Please do include them, and encourage that practice! :)

[WebKit Review Bot]

Comment on attachment 142362 [details]
patch

Clearing flags on attachment: 142362

Committed r117365: <http://trac.webkit.org/changeset/117365>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Dean Jackson]

(In reply to comment #3)
> (From update of attachment 142362 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142362&action=review
> 
> >> LayoutTests/ChangeLog:5
> >> +        <rdar://problem/10751905>
> > 
> > I don't *think* we typically include the radar link in ChangeLogs.
> 
> Please do include them, and encourage that practice! :)

Yeah, I was corrected on IRC. What's crazy is that I've been intentionally leaving them out for years!