Bug 86686 - Crash if SVG gradient stop has display: none set
Summary: Crash if SVG gradient stop has display: none set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-05-16 16:05 PDT by Tim Horton
Modified: 2012-05-17 11:26 PDT (History)
4 users (show)

See Also:

Attachments
patch (3.90 KB, patch)
2012-05-16 16:16 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2012-05-16 16:05:54 PDT 
We crash if an otherwise-valid SVG gradient stop has display: none set, because there is no renderer created, but we depend on it having been created.

I have a patch.

<rdar://problem/10751905>
Comment 1 Tim Horton 2012-05-16 16:16:41 PDT 
Created attachment 142362 [details]
patch
Comment 2 Dean Jackson 2012-05-16 16:29:15 PDT 
Comment on attachment 142362 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142362&action=review

> LayoutTests/ChangeLog:5
> +        <rdar://problem/10751905>

I don't *think* we typically include the radar link in ChangeLogs.
Comment 3 Alexey Proskuryakov 2012-05-16 16:39:47 PDT 
Comment on attachment 142362 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142362&action=review

>> LayoutTests/ChangeLog:5
>> +        <rdar://problem/10751905>
> 
> I don't *think* we typically include the radar link in ChangeLogs.

Please do include them, and encourage that practice! :)
Comment 4 WebKit Review Bot 2012-05-16 17:06:32 PDT 
Comment on attachment 142362 [details]
patch

Clearing flags on attachment: 142362

Committed r117365: <http://trac.webkit.org/changeset/117365>
Comment 5 WebKit Review Bot 2012-05-16 17:06:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Dean Jackson 2012-05-17 11:26:00 PDT 
(In reply to comment #3)
> (From update of attachment 142362 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142362&action=review
> 
> >> LayoutTests/ChangeLog:5
> >> +        <rdar://problem/10751905>
> > 
> > I don't *think* we typically include the radar link in ChangeLogs.
> 
> Please do include them, and encourage that practice! :)

Yeah, I was corrected on IRC. What's crazy is that I've been intentionally leaving them out for years!