Bug 86684 – [chromium] Use overloaded printBegin() webkit api to support auto fit to page functionality

• Status: RESOLVED
• Resolution: FIXED
• Component: Printing

[kmadhusu]

This is a follow up CL of bug 84312 to remove the unused printBegin() function.

[kmadhusu]

Created attachment 142357 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Comment on attachment 142357 [details]
Patch

Attachment 142357 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12722282

[kmadhusu]

You can find webkit_glue.cc changes @http://codereview.chromium.org/10168013/.

[WebKit Review Bot]

Comment on attachment 142357 [details]
Patch

Clearing flags on attachment: 142357

Committed r117675: <http://trac.webkit.org/changeset/117675>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

Re-opened since this is blocked by 86938

[Ryosuke Niwa]

This patch broke builds:

http://build.chromium.org/p/chromium.webkit/builders/Mac%20Builder%20%28dbg%29/builds/7967/steps/compile/logs/stdio

In file included from /b/build/slave/Mac_Builder__dbg_/build/src/third_party/WebKit/Source/WebKit/chromium/src/WebFrameImpl.cpp:162:
public/WebPrintParams.h:67:30: error: field is uninitialized when used here [-Werror,-Wuninitialized]
        , printScalingOption(printScalingOption) { }
                             ^
1 error generated.

You can't initialize member variables by themselves. Please use different names.

[Ryosuke Niwa]

(In reply to comment #8)
> Please use different names.

Ugh... I mean different *values*.

[kmadhusu]

Created attachment 142912 [details]
Patch

[kmadhusu]

oops. It was a typo. Fixed the issue and uploaded a new patch for review.

[kmadhusu]

fishd@: My previous patch was rolled out due to a compile error. Can you review the new patch?

Thanks.

[WebKit Review Bot]

Comment on attachment 142912 [details]
Patch

Clearing flags on attachment: 142912

Committed r118062: <http://trac.webkit.org/changeset/118062>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.