Bug 86675 - Move showStyle from CSSStyleDeclaration to StylePropertySet
Summary: Move showStyle from CSSStyleDeclaration to StylePropertySet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-16 14:31 PDT by Ryosuke Niwa
Modified: 2012-05-16 17:29 PDT (History)
12 users (show)

See Also:

Attachments
Moved (10.73 KB, patch)
2012-05-16 15:58 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixed build (10.96 KB, patch)
2012-05-16 16:00 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-05-16 14:31:00 PDT 
The whole of showStyle was so that we can use it while debugging editing code, which mutates CSS properties quite often. It would be useful if showStyle was in StylePropertySet instead of CSSStyleDeclaration now that the most of internal code uses StylePropertySet.

Also, this function is the only reason we have CSSStyleDeclaration.cpp. We can remove that file once we moved the function.
Comment 1 Ryosuke Niwa 2012-05-16 15:58:47 PDT 
Created attachment 142359 [details]
Moved
Comment 2 Ryosuke Niwa 2012-05-16 16:00:45 PDT 
Created attachment 142360 [details]
Fixed build
Comment 3 Andreas Kling 2012-05-16 16:03:51 PDT 
Comment on attachment 142360 [details]
Fixed build

LGreatTM!
Comment 4 WebKit Review Bot 2012-05-16 17:29:53 PDT 
Comment on attachment 142360 [details]
Fixed build

Clearing flags on attachment: 142360

Committed r117369: <http://trac.webkit.org/changeset/117369>
Comment 5 WebKit Review Bot 2012-05-16 17:29:59 PDT 
All reviewed patches have been landed.  Closing bug.