WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
86675
Move showStyle from CSSStyleDeclaration to StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=86675
Summary
Move showStyle from CSSStyleDeclaration to StylePropertySet
Ryosuke Niwa
Reported
2012-05-16 14:31:00 PDT
The whole of showStyle was so that we can use it while debugging editing code, which mutates CSS properties quite often. It would be useful if showStyle was in StylePropertySet instead of CSSStyleDeclaration now that the most of internal code uses StylePropertySet. Also, this function is the only reason we have CSSStyleDeclaration.cpp. We can remove that file once we moved the function.
Attachments
Moved
(10.73 KB, patch)
2012-05-16 15:58 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
Fixed build
(10.96 KB, patch)
2012-05-16 16:00 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2012-05-16 15:58:47 PDT
Created
attachment 142359
[details]
Moved
Ryosuke Niwa
Comment 2
2012-05-16 16:00:45 PDT
Created
attachment 142360
[details]
Fixed build
Andreas Kling
Comment 3
2012-05-16 16:03:51 PDT
Comment on
attachment 142360
[details]
Fixed build LGreatTM!
WebKit Review Bot
Comment 4
2012-05-16 17:29:53 PDT
Comment on
attachment 142360
[details]
Fixed build Clearing flags on attachment: 142360 Committed
r117369
: <
http://trac.webkit.org/changeset/117369
>
WebKit Review Bot
Comment 5
2012-05-16 17:29:59 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug