Bug 86662 - IndexedDB: Implement IDBObjectStore.autoIncrement
Summary: IndexedDB: Implement IDBObjectStore.autoIncrement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on: 86661
Blocks:
  Show dependency tree / graph
 
Reported: 2012-05-16 11:52 PDT by Joshua Bell
Modified: 2012-05-17 16:02 PDT (History)
10 users (show)

See Also:

Attachments
Patch (12.31 KB, patch)
2012-05-16 11:54 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
Patch for landing (13.13 KB, patch)
2012-05-17 14:46 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-05-16 11:52:24 PDT 
IndexedDB: Implement IDBObjectStore.autoIncrement
Comment 1 Joshua Bell 2012-05-16 11:54:16 PDT 
Created attachment 142317 [details]
Patch
Comment 2 Joshua Bell 2012-05-16 11:57:25 PDT 
Expose this attribute defined in the spec - http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#object-store

Like other properties, this value is stored in the IDBObjectStoreBackendImpl and exposed through the IDBObjectStore indirectly.

Note that http://webkit.org/b/86661 will land the Chromium WebKit API change in Source/WebKit/chromium/public/WebIDBObjectStore.h first so that Chromium can be updated. (This is Part 2 of a 2-sided patch.) Once that lands, this will be rebased before landing.
Comment 3 WebKit Review Bot 2012-05-16 11:57:27 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 WebKit Review Bot 2012-05-16 15:43:09 PDT 
Comment on attachment 142317 [details]
Patch

Attachment 142317 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12701994
Comment 5 Joshua Bell 2012-05-16 15:44:45 PDT 
FYI, the chrome-ews failure is expected as http://codereview.chromium.org/10332204/ hasn't landed yet
Comment 6 Joshua Bell 2012-05-17 14:46:06 PDT 
Created attachment 142558 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-05-17 16:02:24 PDT 
Comment on attachment 142558 [details]
Patch for landing

Clearing flags on attachment: 142558

Committed r117509: <http://trac.webkit.org/changeset/117509>
Comment 8 WebKit Review Bot 2012-05-17 16:02:41 PDT 
All reviewed patches have been landed.  Closing bug.