Bug 86632 - Web Inspector: Support script snippets saving.
: Web Inspector: Support script snippets saving.
Status: RESOLVED FIXED
: WebKit
Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
: 75094
  Show dependency treegraph
 
Reported: 2012-05-16 07:41 PST by
Modified: 2012-05-16 09:11 PST (History)


Attachments
Patch (17.78 KB, patch)
2012-05-16 08:12 PST, Vsevolod Vlasov
pfeldman: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-05-16 07:41:26 PST
Patch to follow
------- Comment #1 From 2012-05-16 08:12:23 PST -------
Created an attachment (id=142264) [details]
Patch
------- Comment #2 From 2012-05-16 08:39:01 PST -------
(From update of attachment 142264 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=142264&action=review

> Source/WebCore/inspector/front-end/ScriptSnippetModel.js:299
> +    * @param {WebInspector.ContentProvider} contentProvider

Wrong indent.

> Source/WebCore/inspector/front-end/ScriptSnippetModel.js:323
> +            callback();

Why conditional?
------- Comment #3 From 2012-05-16 09:11:01 PST -------
Committed r117299: <http://trac.webkit.org/changeset/117299>