Bug 86632 - Web Inspector: Support script snippets saving.
: Web Inspector: Support script snippets saving.
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Vsevolod Vlasov
:
Depends on:
Blocks: 75094
  Show dependency treegraph
 
Reported: 2012-05-16 07:41 PDT by Vsevolod Vlasov
Modified: 2012-05-16 09:11 PDT (History)
10 users (show)

See Also:


Attachments
Patch (17.78 KB, patch)
2012-05-16 08:12 PDT, Vsevolod Vlasov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-05-16 07:41:26 PDT
Patch to follow
Comment 1 Vsevolod Vlasov 2012-05-16 08:12:23 PDT
Created attachment 142264 [details]
Patch
Comment 2 Pavel Feldman 2012-05-16 08:39:01 PDT
Comment on attachment 142264 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142264&action=review

> Source/WebCore/inspector/front-end/ScriptSnippetModel.js:299
> +    * @param {WebInspector.ContentProvider} contentProvider

Wrong indent.

> Source/WebCore/inspector/front-end/ScriptSnippetModel.js:323
> +            callback();

Why conditional?
Comment 3 Vsevolod Vlasov 2012-05-16 09:11:01 PDT
Committed r117299: <http://trac.webkit.org/changeset/117299>