Bug 86622 - NEON intrinsic should be used with arithmetic mode of composite filter
Summary: NEON intrinsic should be used with arithmetic mode of composite filter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-16 06:56 PDT by Zoltan Herczeg
Modified: 2012-05-17 02:12 PDT (History)
3 users (show)

See Also:

Attachments
EWS test (20.74 KB, patch)
2012-05-16 06:56 PDT, Zoltan Herczeg 		no flags Details | Formatted Diff | Diff
EWS test (20.99 KB, patch)
2012-05-16 07:00 PDT, Zoltan Herczeg 		no flags Details | Formatted Diff | Diff
patch (22.52 KB, patch)
2012-05-16 23:50 PDT, Zoltan Herczeg 		zimmermann: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Herczeg 2012-05-16 06:56:08 PDT 
Let's do it
Comment 1 Zoltan Herczeg 2012-05-16 06:56:39 PDT 
Created attachment 142245 [details]
EWS test
Comment 2 Zoltan Herczeg 2012-05-16 07:00:22 PDT 
Created attachment 142248 [details]
EWS test

Sorry, wrong patch before
Comment 3 WebKit Review Bot 2012-05-16 07:03:54 PDT 
Attachment 142248 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Zoltan Herczeg 2012-05-16 23:50:54 PDT 
Created attachment 142424 [details]
patch
Comment 5 Nikolas Zimmermann 2012-05-17 00:04:49 PDT 
Comment on attachment 142424 [details]
patch

Wow, this looks much better, rs=me.
I trust you that the intrinsics stuff is correct, can't really review that properly.
Comment 6 Zoltan Herczeg 2012-05-17 02:12:28 PDT 
Thanks for the review.

Landed as trac.webkit.org/changeset/117418