This adds evaluateOptions parameter exposed on InspectedWindow.eval() and SidebarPane.setExpression() in r116957 to "node" and "expression" audit formatters. See also bug 86361 and bug 86108.
Created attachment 142242 [details] Patch
Attachment 142242 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1 LayoutTests/platform/gtk/test_expectations.txt:785: Path does not exist. inspector/debugger/snippets-model.html [test/expectations] [5] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 142242 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142242&action=review > Source/WebCore/inspector/front-end/AuditFormatters.js:32 > + * @param {*} value Could you whitelist the types? > Source/WebCore/inspector/front-end/AuditFormatters.js:69 > + */ Please do not declare properties on WebInspector. > Source/WebCore/inspector/front-end/AuditFormatters.js:72 > + if (Array.isArray(value)) value instanceof Array > Source/WebCore/inspector/front-end/ExtensionAuditCategory.js:34 > + * @param {*} id * ? > Source/WebCore/inspector/front-end/ExtensionAuditCategory.js:72 > + * @param {function(WebInspector.AuditRuleResult):*} callback no need to declare :*
Committed r117293: <http://trac.webkit.org/changeset/117293>