Bug 86617 - Web Inspector: [Extensions API] expose evaluateOptions in audit formatters
Summary: Web Inspector: [Extensions API] expose evaluateOptions in audit formatters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-16 06:22 PDT by Andrey Kosyakov
Modified: 2012-05-16 08:41 PDT (History)
10 users (show)

See Also:


Attachments
Patch (18.87 KB, patch)
2012-05-16 06:30 PDT, Andrey Kosyakov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-05-16 06:22:14 PDT
This adds evaluateOptions parameter exposed on InspectedWindow.eval() and SidebarPane.setExpression() in r116957 to "node" and "expression" audit formatters.
See also bug 86361 and bug 86108.
Comment 1 Andrey Kosyakov 2012-05-16 06:30:09 PDT
Created attachment 142242 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-16 06:33:58 PDT
Attachment 142242 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1
LayoutTests/platform/gtk/test_expectations.txt:785:  Path does not exist. inspector/debugger/snippets-model.html  [test/expectations] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Pavel Feldman 2012-05-16 07:45:12 PDT
Comment on attachment 142242 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142242&action=review

> Source/WebCore/inspector/front-end/AuditFormatters.js:32
> + * @param {*} value

Could you whitelist the types?

> Source/WebCore/inspector/front-end/AuditFormatters.js:69
> + */

Please do not declare properties on WebInspector.

> Source/WebCore/inspector/front-end/AuditFormatters.js:72
> +    if (Array.isArray(value)) 

value instanceof Array

> Source/WebCore/inspector/front-end/ExtensionAuditCategory.js:34
> + * @param {*} id

* ?

> Source/WebCore/inspector/front-end/ExtensionAuditCategory.js:72
> + * @param {function(WebInspector.AuditRuleResult):*} callback

no need to declare :*
Comment 4 Andrey Kosyakov 2012-05-16 08:40:37 PDT
Committed r117293: <http://trac.webkit.org/changeset/117293>