Layout tests which fails because of it: editing/deleting/5408255.html editing/deleting/regional-indicators.html
Created attachment 146832 [details] Fixing delete button implementation
Comment on attachment 146832 [details] Fixing delete button implementation LGTM.
Comment on attachment 146832 [details] Fixing delete button implementation Ok, looks good to me.
LGTM. CC'ing reviewers.
Comment on attachment 146832 [details] Fixing delete button implementation View in context: https://bugs.webkit.org/attachment.cgi?id=146832&action=review Sorry for being late to the party, but I object to this. The comment the unskipped test deletionUI-single-instance.html summarizes what this whole feature seems to boil down to: something Apple-specific we should not have to worry about. The Qt and Chromium ports only implement shouldShowDeleteInterface for testing purposes, and the only port besides the Apple ones that emits a signal for end users about this is the GTK+ one, and even there it does not seem to be properly documented. > Source/WebCore/ChangeLog:11 > + * platform/efl/SharedBufferEfl.cpp: > + (WebCore::SharedBuffer::createWithContentsOfFile): Fix creation of shared buffer from image This has been fixed in r121254. > Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:66 > + return element->getAttribute(HTMLNames::classAttr) == "needsDeletionUI"; This seems to be an Apple-specific attribute.
I'm moving these tests into platform/mac.