RESOLVED FIXED86604
Web Inspector: Move edit/save script source logic to JavaScriptSource. 
https://bugs.webkit.org/show_bug.cgi?id=86604
Summary Web Inspector: Move edit/save script source logic to JavaScriptSource.
Vsevolod Vlasov
Reported 2012-05-16 03:07:00 PDT
Patch to follow.
Attachments
Patch (27.39 KB, patch)
2012-05-16 04:40 PDT, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-05-16 04:40:58 PDT
Created attachment 142223 [details] Patch
Pavel Feldman
Comment 2 2012-05-16 05:05:48 PDT
Comment on attachment 142223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142223&action=review > Source/WebCore/inspector/front-end/DebuggerResourceBinding.js:47 > WebInspector.DebuggerResourceBinding.canEditScriptSource = function(uiSourceCode) Thsi method should no longer exist. > Source/WebCore/inspector/front-end/JavaScriptSource.js:172 > + return WebInspector.DebuggerResourceBinding.canEditScriptSource(this) && this._isEditable; just inline it. > Source/WebCore/inspector/front-end/NavigatorView.js:59 > + this._boundUISourceCodeWorkingCopyChanged = this._uiSourceCodeWorkingCopyChanged.bind(this); You don't have to bind methods for removing them, just use the "listener, this)" notation. > Source/WebCore/inspector/front-end/TabbedEditorContainer.js:67 > + this._boundUISourceCodeWorkingCopyChanged = this._uiSourceCodeWorkingCopyChanged.bind(this); ditto
Vsevolod Vlasov
Comment 3 2012-05-16 05:40:42 PDT
Committed r117269: <http://trac.webkit.org/changeset/117269>
Note You need to log in before you can comment on or make changes to this bug.