WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
86601
Web Inspector: get rid of UISourceCodeListChanged event.
https://bugs.webkit.org/show_bug.cgi?id=86601
Summary
Web Inspector: get rid of UISourceCodeListChanged event.
Pavel Feldman
Reported
2012-05-16 02:34:59 PDT
There was unnecessary conversion between this event and UISourceCodeAdded/Removed/Replaced.
Attachments
Patch
(30.29 KB, patch)
2012-05-16 04:33 PDT
,
Pavel Feldman
vsevik
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2012-05-16 04:33:52 PDT
Created
attachment 142220
[details]
Patch
Vsevolod Vlasov
Comment 2
2012-05-16 05:20:17 PDT
Comment on
attachment 142220
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=142220&action=review
> Source/WebCore/inspector/front-end/NavigatorView.js:-147 > - if (!added)
This two lines are still needed here.
> Source/WebCore/inspector/front-end/ResourceScriptMapping.js:167 > + var scriptIds = [];
Please remove this unused array here and in the method above.
> LayoutTests/inspector/debugger/scripts-panel-expected.txt:33 > + source.js
A script in Content scripts tab looks weird.
Pavel Feldman
Comment 3
2012-05-16 05:21:45 PDT
Committed
r117267
: <
http://trac.webkit.org/changeset/117267
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug