Bug 86601 - Web Inspector: get rid of UISourceCodeListChanged event.
Summary: Web Inspector: get rid of UISourceCodeListChanged event.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-16 02:34 PDT by Pavel Feldman
Modified: 2012-05-16 05:21 PDT (History)
10 users (show)

See Also:


Attachments
Patch (30.29 KB, patch)
2012-05-16 04:33 PDT, Pavel Feldman
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-05-16 02:34:59 PDT
There was unnecessary conversion between this event and UISourceCodeAdded/Removed/Replaced.
Comment 1 Pavel Feldman 2012-05-16 04:33:52 PDT
Created attachment 142220 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-05-16 05:20:17 PDT
Comment on attachment 142220 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142220&action=review

> Source/WebCore/inspector/front-end/NavigatorView.js:-147
> -        if (!added)

This two lines are still needed here.

> Source/WebCore/inspector/front-end/ResourceScriptMapping.js:167
> +        var scriptIds = [];

Please remove this unused array here and in the method above.

> LayoutTests/inspector/debugger/scripts-panel-expected.txt:33
> +  source.js

A script in Content scripts tab looks weird.
Comment 3 Pavel Feldman 2012-05-16 05:21:45 PDT
Committed r117267: <http://trac.webkit.org/changeset/117267>