Bug 86589 – [Chromium] WebTransformationMatrixTest.verifyDefaultConstructorCreatesIdentityMatrix is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Kenichi Ishibashi]

The test didn't complete all platform.
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20%28dbg%29%281%29/builds/12336
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28dbg%29%281%29/builds/7239
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux%20%28dbg%29/builds/6817

[Kenichi Ishibashi]

Created attachment 142202 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Kenichi Ishibashi]

The failure is caused by the assertion at WebPrivateOwnPtr::~WebPrivateOwnPtr().

Kent-san, could you take a look?

[Kent Tamura]

Comment on attachment 142202 [details]
Patch

ok

[Kenichi Ishibashi]

(In reply to comment #4)
> (From update of attachment 142202 [details])
> ok

Thanks!

[WebKit Review Bot]

Comment on attachment 142202 [details]
Patch

Clearing flags on attachment: 142202

Committed r117257: <http://trac.webkit.org/changeset/117257>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Shawn Singh]

Thank you for fixing this, I apologize you had to do it on my behalf

[James Robinson]

Comment on attachment 142202 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142202&action=review

> Source/Platform/chromium/public/WebTransformationMatrix.h:54
> +    ~WebTransformationMatrix();

we typically have this declared inline and call a exported reset() function. this class is still in a bit of flux, though (it doesn't have proper exports yet, for instance)