Bug 86567 - Add new build slave for EFL port
Summary: Add new build slave for EFL port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-15 21:08 PDT by Gyuyoung Kim
Modified: 2012-05-17 06:48 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.49 KB, patch)
2012-05-15 21:20 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-05-15 21:08:17 PDT
Add new build slave for EFL 32-bit linux build. I verify that this build slave works according to http://trac.webkit.org/wiki/BuildBot guidance. Though I wanted to run Build and Test bot, unfortunately, I could run build bot because of  PC hardware performance. However,  when I have more powerful PC, I will change this with Build and Test bot in future.
Comment 1 Gyuyoung Kim 2012-05-15 21:20:24 PDT
Created attachment 142139 [details]
Patch
Comment 2 Gyuyoung Kim 2012-05-15 21:45:49 PDT
CC'ing Ryosuke.
Comment 3 Eric Seidel (no email) 2012-05-16 18:12:08 PDT
I don't know who reviews these these days.  I used to use aroben for this sort of thing. :)
Comment 4 WebKit Review Bot 2012-05-16 19:18:08 PDT
Comment on attachment 142139 [details]
Patch

Clearing flags on attachment: 142139

Committed r117380: <http://trac.webkit.org/changeset/117380>
Comment 5 WebKit Review Bot 2012-05-16 19:18:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Gyuyoung Kim 2012-05-16 19:49:06 PDT
William,

Though this patch is landed, new EFL build slave isn't added to waterfall. I wonder whether buildbot master needs to be restarted.
Comment 7 Ryosuke Niwa 2012-05-16 20:12:23 PDT
(In reply to comment #6)
> William,
> 
> Though this patch is landed, new EFL build slave isn't added to waterfall. I wonder whether buildbot master needs to be restarted.

Maybe there's a syntax error? Did you confirm that your config file is correct by loading it on your local machine?
Comment 8 Gyuyoung Kim 2012-05-16 21:46:03 PDT
(In reply to comment #7)
> (In reply to comment #6)
> > William,
> > 
> > Though this patch is landed, new EFL build slave isn't added to waterfall. I wonder whether buildbot master needs to be restarted.
> 
> Maybe there's a syntax error? Did you confirm that your config file is correct by loading it on your local machine?

I just tested it on my local buildbot. You can it at below link.

http://50.17.188.232:8710/waterfall?category=EFL

Do I need to modify other configuration files except for config.json ?
Comment 9 William Siegrist 2012-05-17 06:48:35 PDT
You also need to request a password for the slave. The restart will fail if you mention a slave with no password in the config. I'll send the password details to Gyuyoung in email. The slave has been added and the master restarted.