Bug 86564 - Change printf to fprintf in DEBUG_AUDIONODE_REFERENCES
Summary: Change printf to fprintf in DEBUG_AUDIONODE_REFERENCES
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-15 20:22 PDT by Raymond Toy
Modified: 2012-06-19 10:18 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.74 KB, patch)
2012-06-19 02:59 PDT, Andrei Poenaru
no flags Details | Formatted Diff | Diff
Patch (3.79 KB, patch)
2012-06-19 04:23 PDT, Andrei Poenaru
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raymond Toy 2012-05-15 20:22:42 PDT
The debugging prints for DEBUG_AUDIONODE_REFERENCES use printf, but it's nicer to fprintf instead so that the debugging messages aren't all buffered up and printed whenever stdio decides to output the buffer.  It makes it easier to follow things as they happen.
Comment 1 Andrei Poenaru 2012-06-19 02:59:09 PDT
Created attachment 148297 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-19 03:05:07 PDT
Attachment 148297 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:10:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andrei Poenaru 2012-06-19 04:23:19 PDT
Created attachment 148310 [details]
Patch
Comment 4 Csaba Osztrogonác 2012-06-19 05:32:42 PDT
Comment on attachment 148310 [details]
Patch

LGTM, r=me.
Comment 5 WebKit Review Bot 2012-06-19 06:59:34 PDT
Comment on attachment 148310 [details]
Patch

Clearing flags on attachment: 148310

Committed r120707: <http://trac.webkit.org/changeset/120707>
Comment 6 WebKit Review Bot 2012-06-19 06:59:40 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Raymond Toy 2012-06-19 10:18:48 PDT
(In reply to comment #4)
> (From update of attachment 148310 [details])
> LGTM, r=me.

A bit too late, but doesn't AudioNode.cpp need to include <stdio.h> when DEBUG_AUDIONODE_REFERENCES is non-zero?  I think I needed this on linux.