Bug 86563 - BitmapImage wastes vector capacity
Summary: BitmapImage wastes vector capacity
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 86281
  Show dependency treegraph
 
Reported: 2012-05-15 20:21 PDT by Simon Fraser (smfr)
Modified: 2012-06-25 18:26 PDT (History)
3 users (show)

See Also:


Attachments
Reduce BitmapImage Vector memory footprint via inline capacity of 1 (2.95 KB, patch)
2012-06-25 14:06 PDT, Nick Carter
simon.fraser: review+
simon.fraser: commit-queue-
Details | Formatted Diff | Diff
Reduce BitmapImage Vector memory footprint via inline capacity of 1 (no tabs) (2.95 KB, patch)
2012-06-25 15:05 PDT, Nick Carter
webkit.review.bot: review-
atwilson: commit-queue+
Details | Formatted Diff | Diff
Reduce BitmapImage Vector memory footprint via inline capacity of 1 (no tabs, no whitespace diffs) (2.36 KB, patch)
2012-06-25 15:19 PDT, Nick Carter
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-05-15 20:21:08 PDT
97 vectors, 1.38KB used of 22.12KB, 20.74KB wasted at:
1   0x108ce9fc8 WTF::Vector<WebCore::FrameData, 0ul>::Vector(unsigned long)
2   0x108ce8b2b WebCore::BitmapImage::BitmapImage(WebCore::ImageObserver*)
3   0x108cf72c4 WebCore::CachedImage::createImage()
4   0x108cf6a89 WebCore::CachedImage::data(WTF::PassRefPtr<WebCore::SharedBuffer>, bool)
5   0x1096e7a4e WebCore::SubresourceLoader::sendDataToResource(char const*, int)
Comment 1 Nick Carter 2012-06-25 14:06:15 PDT
Created attachment 149355 [details]
Reduce BitmapImage Vector memory footprint via inline capacity of 1

I noticed this issue independently; I think this patch will fix it.
Comment 2 WebKit Review Bot 2012-06-25 14:09:45 PDT
Attachment 149355 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:4:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2012-06-25 14:50:01 PDT
Comment on attachment 149355 [details]
Reduce BitmapImage Vector memory footprint via inline capacity of 1

No tabs please.
Comment 4 Nick Carter 2012-06-25 15:05:05 PDT
Created attachment 149365 [details]
Reduce BitmapImage Vector memory footprint via inline capacity of 1 (no tabs)

Removed the tabs.
Comment 5 WebKit Review Bot 2012-06-25 15:07:26 PDT
Comment on attachment 149365 [details]
Reduce BitmapImage Vector memory footprint via inline capacity of 1 (no tabs)

Rejecting attachment 149365 [details] from review queue.

nick@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 6 Nick Carter 2012-06-25 15:19:26 PDT
Created attachment 149366 [details]
Reduce BitmapImage Vector memory footprint via inline capacity of 1 (no tabs, no whitespace diffs)

Sorry for the confusion here; this is my first contribution.
Comment 7 WebKit Review Bot 2012-06-25 18:26:31 PDT
Comment on attachment 149366 [details]
Reduce BitmapImage Vector memory footprint via inline capacity of 1 (no tabs, no whitespace diffs)

Clearing flags on attachment: 149366

Committed r121208: <http://trac.webkit.org/changeset/121208>
Comment 8 WebKit Review Bot 2012-06-25 18:26:38 PDT
All reviewed patches have been landed.  Closing bug.