Bug 86563 – BitmapImage wastes vector capacity

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Simon Fraser (smfr)]

97 vectors, 1.38KB used of 22.12KB, 20.74KB wasted at:
1   0x108ce9fc8 WTF::Vector<WebCore::FrameData, 0ul>::Vector(unsigned long)
2   0x108ce8b2b WebCore::BitmapImage::BitmapImage(WebCore::ImageObserver*)
3   0x108cf72c4 WebCore::CachedImage::createImage()
4   0x108cf6a89 WebCore::CachedImage::data(WTF::PassRefPtr<WebCore::SharedBuffer>, bool)
5   0x1096e7a4e WebCore::SubresourceLoader::sendDataToResource(char const*, int)

[Nick Carter]

Created attachment 149355 [details]
Reduce BitmapImage Vector memory footprint via inline capacity of 1

I noticed this issue independently; I think this patch will fix it.

[WebKit Review Bot]

Attachment 149355 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:4:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 149355 [details]
Reduce BitmapImage Vector memory footprint via inline capacity of 1

No tabs please.

[Nick Carter]

Created attachment 149365 [details]
Reduce BitmapImage Vector memory footprint via inline capacity of 1 (no tabs)

Removed the tabs.

[WebKit Review Bot]

Comment on attachment 149365 [details]
Reduce BitmapImage Vector memory footprint via inline capacity of 1 (no tabs)

Rejecting attachment 149365 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[Nick Carter]

Created attachment 149366 [details]
Reduce BitmapImage Vector memory footprint via inline capacity of 1 (no tabs, no whitespace diffs)

Sorry for the confusion here; this is my first contribution.

[WebKit Review Bot]

Comment on attachment 149366 [details]
Reduce BitmapImage Vector memory footprint via inline capacity of 1 (no tabs, no whitespace diffs)

Clearing flags on attachment: 149366

Committed r121208: <http://trac.webkit.org/changeset/121208>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.