Bug 86556 – [Worker] Web Worker lacks test for posting structured data message.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Li Yin]

From http://www.w3.org/TR/2012/CR-workers-20120501/#communicating-with-a-dedicated-worker
Structured data can be sent over this communication channel.
worker.postMessage({
  operation: 'find-edges',
  input: buffer, // an ArrayBuffer object
  threshold: 0.6,
}, [buffer]);

[Li Yin]

Created attachment 142121 [details]
Patch

[David Levin]

Comment on attachment 142121 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142121&action=review

Seems ok. Just a few nits to fix up.

> LayoutTests/fast/workers/resources/worker-structure-message.js:7
> +        var buf = new ArrayBuffer(20);

Why is this allocated here? I don't see it being used.

> LayoutTests/fast/workers/worker-structure-message.html:5
> +Should print "DONE" when done.</p>

On success, you should see...

[Li Yin]

Created attachment 142129 [details]
Patch

[Li Yin]

(In reply to comment #2)
> (From update of attachment 142121 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142121&action=review
> 
> Seems ok. Just a few nits to fix up.
> 
> > LayoutTests/fast/workers/resources/worker-structure-message.js:7
> > +        var buf = new ArrayBuffer(20);
> 
> Why is this allocated here? I don't see it being used.

Sorry, forget to delete. Now it has been deleted.
> 
> > LayoutTests/fast/workers/worker-structure-message.html:5
> > +Should print "DONE" when done.</p>
> 
> On success, you should see...

Add the related log.

Thanks for your review.

[David Levin]

You can set cq? when you set r? and save a step :) for everyone.

[Li Yin]

(In reply to comment #5)
> You can set cq? when you set r? and save a step :) for everyone.

:) Thanks for your reminding.

[WebKit Review Bot]

Comment on attachment 142129 [details]
Patch

Clearing flags on attachment: 142129

Committed r117220: <http://trac.webkit.org/changeset/117220>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.