Bug 86539 – [chromium] Contents flash when switching tabs when composting, due to drawing when content texture manager limit is 0.

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Michal Mocny]

[chromium] Contents flash when switching tabs when composting, due to drawing when content texture manager limit is 0.

[Michal Mocny]

Created attachment 142085 [details]
Patch

[Michal Mocny]

Notes on the approach here:

1. We would prefer not to manually increase memory when a tab is foregrounded to get around the issue of drawing white frames, but this is a temporary solution until that larger problem is solved.  Specifically, this is also happening without threaded compositor and it is unclear if https://bugs.webkit.org/show_bug.cgi?id=85108 fixes that, or if it will land soon.

2. Regarding early exit in setContentsMemoryAllocationLimitBytes, @danakj suggested we add a tag to the memory allocation struct saying "expected visibility".  Then, we can early exit whenever the current state is != expected state, without specifically testing for bytes == 0.

[Dana Jansens]

(In reply to comment #2)
> Notes on the approach here:
> 
> 1. We would prefer not to manually increase memory when a tab is foregrounded to get around the issue of drawing white frames, but this is a temporary solution until that larger problem is solved.  Specifically, this is also happening without threaded compositor and it is unclear if https://bugs.webkit.org/show_bug.cgi?id=85108 fixes that, or if it will land soon.

I *think* if we also make CCSingleThreadProxy skip drawing frames where prepareToDraw() fails, then bug #85108 would fix this problem. That could be done as a simple followup to 85108, or along with it.

[Nat Duca]

agreed with dana

[Michal Mocny]

*** This bug has been marked as a duplicate of bug 85108 ***

[Adam Barth]

Comment on attachment 142085 [details]
Patch

Cleared review? from attachment 142085 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).