RESOLVED FIXED 86538
CopiedSpace::doneCopying could start another collection 
https://bugs.webkit.org/show_bug.cgi?id=86538
Summary CopiedSpace::doneCopying could start another collection
Mark Hahnenberg
Reported 2012-05-15 15:35:53 PDT
It's possible that if we don't have anything at the head of to-space after a collection and the BlockAllocator doesn't have any fresh blocks to give us right now we could start another collection while still in the middle of the first collection when we call CopiedSpace::addNewBlock(). One way to resolve this would be to have Heap::shouldCollect() check that m_operationInProgress is NoOperation. This would prevent the path in getFreshBlock() that starts the collection if we're already in the middle of one.
Attachments
Patch (2.13 KB, patch)
2012-05-15 15:42 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2012-05-15 15:42:41 PDT
Created attachment 142084 [details] Patch
Mark Hahnenberg
Comment 2 2012-05-15 15:49:16 PDT
<rdar://problem/11459513>
Mark Hahnenberg
Comment 3 2012-05-29 10:41:19 PDT
*** Bug 87723 has been marked as a duplicate of this bug. ***
Geoffrey Garen
Comment 4 2012-05-29 10:46:48 PDT
Comment on attachment 142084 [details] Patch r=me
WebKit Review Bot
Comment 5 2012-05-29 11:38:33 PDT
Comment on attachment 142084 [details] Patch Clearing flags on attachment: 142084 Committed r118810: <http://trac.webkit.org/changeset/118810>
WebKit Review Bot
Comment 6 2012-05-29 11:38:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.