Bug 86537 - [chromium] Chromium port never sets USE(CG) so code behind it is dead
Summary: [chromium] Chromium port never sets USE(CG) so code behind it is dead
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-15 15:19 PDT by James Robinson
Modified: 2012-05-15 16:58 PDT (History)
5 users (show)

See Also:

Attachments
Patch (20.47 KB, patch)
2012-05-15 15:21 PDT, James Robinson 		enne: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-05-15 15:19:28 PDT 
[chromium] Chromium port never sets USE(CG) so code behind it is dead
Comment 1 James Robinson 2012-05-15 15:21:09 PDT 
Created attachment 142077 [details]
Patch
Comment 2 Adrienne Walker 2012-05-15 15:33:12 PDT 
Comment on attachment 142077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142077&action=review

Nice.  R=me.

> Source/WebCore/platform/chromium/ThemeChromiumMac.mm:37
>  #include "PlatformContextSkia.h"

This isn't a style header sorting error?
Comment 3 James Robinson 2012-05-15 15:35:31 PDT 
(In reply to comment #2)
> (From update of attachment 142077 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142077&action=review
> 
> Nice.  R=me.
> 
> > Source/WebCore/platform/chromium/ThemeChromiumMac.mm:37
> >  #include "PlatformContextSkia.h"
> 
> This isn't a style header sorting error?

It's the first #include in the file (the others are #import, which sorts alphabetically before #include)
Comment 4 James Robinson 2012-05-15 16:58:11 PDT 
Committed r117190: <http://trac.webkit.org/changeset/117190>