Bug 86526 - initial flex value should be 1 1 auto
Summary: initial flex value should be 1 1 auto
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
Depends on:
Blocks: 62048
  Show dependency treegraph
Reported: 2012-05-15 14:21 PDT by Tony Chang
Modified: 2012-05-31 20:33 PDT (History)
6 users (show)

See Also:

Patch (71.06 KB, patch)
2012-05-31 13:56 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cq-02 (495.12 KB, application/zip)
2012-05-31 17:52 PDT, WebKit Review Bot
no flags Details
Patch for landing (76.36 KB, patch)
2012-05-31 19:18 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-05-15 14:21:49 PDT
It's currently 0 0 auto.

This changed in a recent F2F.  The desire is for flex items to flex by default.
Comment 1 Tony Chang 2012-05-18 10:36:42 PDT
Note: The implications for omitted negative flex are still being discussed:
Comment 2 Tony Chang 2012-05-31 13:56:39 PDT
Created attachment 145151 [details]
Comment 3 WebKit Review Bot 2012-05-31 17:52:42 PDT
Comment on attachment 145151 [details]

Rejecting attachment 145151 [details] from commit-queue.

New failing tests:
Full output: http://queues.webkit.org/results/12868356
Comment 4 WebKit Review Bot 2012-05-31 17:52:46 PDT
Created attachment 145182 [details]
Archive of layout-test-results from ec2-cq-02

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 5 Tony Chang 2012-05-31 19:18:00 PDT
Created attachment 145195 [details]
Patch for landing
Comment 6 Tony Chang 2012-05-31 19:19:18 PDT
The render tree results for fast/multicol/span/clone-flexbox.html might not be exactly correct for some platforms.  I tried to guess the size based on how it turned out in Chromium.  Feel free to rebaseline if the size of the anonymous RenderBlock is wrong.
Comment 7 WebKit Review Bot 2012-05-31 20:33:07 PDT
Comment on attachment 145195 [details]
Patch for landing

Clearing flags on attachment: 145195

Committed r119191: <http://trac.webkit.org/changeset/119191>
Comment 8 WebKit Review Bot 2012-05-31 20:33:13 PDT
All reviewed patches have been landed.  Closing bug.