WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
86520
Implement run-in remove child cases.
https://bugs.webkit.org/show_bug.cgi?id=86520
Summary
Implement run-in remove child cases.
Abhishek Arya
Reported
2012-05-15 13:48:43 PDT
part 2 of
https://bugs.webkit.org/show_bug.cgi?id=86387
e.g. <!-- 'this should' be visible --> <!DOCTYPE html> <html> <style> .runin { display: run-in } </style> </head> <body> <div> <div class="runin">This should </div> <div id="t1">run in.</div> </div> </body> <script> document.body.offsetTop; document.getElementById('t1').style.display = 'none'; </script> </html> <!-- 'this should' be visible and be on a separate line --> <!DOCTYPE html> <html> <style> .runin { display: run-in } </style> </head> <body> <div> <div class="runin">This should </div> <div id="t1">run in.</div> </div> </body> <script> document.body.offsetTop; document.getElementById('t1').style.display = 'inline'; </script> </html>
Attachments
Patch
(5.77 KB, patch)
2013-05-07 09:23 PDT
,
Igor Trindade Oliveira
no flags
Details
Formatted Diff
Diff
Patch
(5.95 KB, patch)
2013-05-10 16:14 PDT
,
Igor Trindade Oliveira
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Abhishek Arya
Comment 1
2012-05-17 15:30:06 PDT
Note that the implementation was still missing before
http://trac.webkit.org/changeset/117482
.
Igor Trindade Oliveira
Comment 2
2013-05-07 09:23:50 PDT
Created
attachment 200915
[details]
Patch Proposed patch.
Robert Hogan
Comment 3
2013-05-09 14:51:36 PDT
Comment on
attachment 200915
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=200915&action=review
> Source/WebCore/rendering/RenderBlock.cpp:2006 > - destroyRunIn(oldRunIn); > > // Add the run-in block as our previous sibling. > parent()->addChild(newRunIn, this); > + destroyRunIn(oldRunIn);
What's going on here? Seems worth a comment in the changelog at least!
Igor Trindade Oliveira
Comment 4
2013-05-10 16:14:01 PDT
Created
attachment 201437
[details]
Patch Proposed patch.
Dave Hyatt
Comment 5
2013-05-15 12:20:13 PDT
Comment on
attachment 201437
[details]
Patch r=me
WebKit Commit Bot
Comment 6
2013-05-15 15:58:46 PDT
Comment on
attachment 201437
[details]
Patch Clearing flags on attachment: 201437 Committed
r150155
: <
http://trac.webkit.org/changeset/150155
>
WebKit Commit Bot
Comment 7
2013-05-15 15:58:49 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug