part 2 of https://bugs.webkit.org/show_bug.cgi?id=86387 e.g. <!-- 'this should' be visible --> <!DOCTYPE html> <html> <style> .runin { display: run-in } </style> </head> <body> <div> <div class="runin">This should </div> <div id="t1">run in.</div> </div> </body> <script> document.body.offsetTop; document.getElementById('t1').style.display = 'none'; </script> </html> <!-- 'this should' be visible and be on a separate line --> <!DOCTYPE html> <html> <style> .runin { display: run-in } </style> </head> <body> <div> <div class="runin">This should </div> <div id="t1">run in.</div> </div> </body> <script> document.body.offsetTop; document.getElementById('t1').style.display = 'inline'; </script> </html>
Note that the implementation was still missing before http://trac.webkit.org/changeset/117482.
Created attachment 200915 [details] Patch Proposed patch.
Comment on attachment 200915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200915&action=review > Source/WebCore/rendering/RenderBlock.cpp:2006 > - destroyRunIn(oldRunIn); > > // Add the run-in block as our previous sibling. > parent()->addChild(newRunIn, this); > + destroyRunIn(oldRunIn); What's going on here? Seems worth a comment in the changelog at least!
Created attachment 201437 [details] Patch Proposed patch.
Comment on attachment 201437 [details] Patch r=me
Comment on attachment 201437 [details] Patch Clearing flags on attachment: 201437 Committed r150155: <http://trac.webkit.org/changeset/150155>
All reviewed patches have been landed. Closing bug.