Bug 86520 - Implement run-in remove child cases.
Summary: Implement run-in remove child cases.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 93304
  Show dependency treegraph
 
Reported: 2012-05-15 13:48 PDT by Abhishek Arya
Modified: 2013-05-15 15:58 PDT (History)
10 users (show)

See Also:


Attachments
Patch (5.77 KB, patch)
2013-05-07 09:23 PDT, Igor Trindade Oliveira
no flags Details | Formatted Diff | Diff
Patch (5.95 KB, patch)
2013-05-10 16:14 PDT, Igor Trindade Oliveira
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Abhishek Arya 2012-05-15 13:48:43 PDT
part 2 of https://bugs.webkit.org/show_bug.cgi?id=86387

e.g.
<!-- 'this should' be visible -->
<!DOCTYPE html>
<html>
<style>
.runin { display: run-in }
</style>
</head>
<body>
<div>
    <div class="runin">This should </div>
    <div id="t1">run in.</div>
</div>
</body>
<script>
document.body.offsetTop;
document.getElementById('t1').style.display = 'none';
</script>
</html>

<!-- 'this should' be visible and be on a separate line -->
<!DOCTYPE html>
<html>
<style>
.runin { display: run-in }
</style>
</head>
<body>
<div>
    <div class="runin">This should </div>
    <div id="t1">run in.</div>
</div>
</body>
<script>
document.body.offsetTop;
document.getElementById('t1').style.display = 'inline';
</script>
</html>
Comment 1 Abhishek Arya 2012-05-17 15:30:06 PDT
Note that the implementation was still missing before http://trac.webkit.org/changeset/117482.
Comment 2 Igor Trindade Oliveira 2013-05-07 09:23:50 PDT
Created attachment 200915 [details]
Patch

Proposed patch.
Comment 3 Robert Hogan 2013-05-09 14:51:36 PDT
Comment on attachment 200915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200915&action=review

> Source/WebCore/rendering/RenderBlock.cpp:2006
> -    destroyRunIn(oldRunIn);
>  
>      // Add the run-in block as our previous sibling.
>      parent()->addChild(newRunIn, this);
> +    destroyRunIn(oldRunIn);

What's going on here? Seems worth a comment in the changelog at least!
Comment 4 Igor Trindade Oliveira 2013-05-10 16:14:01 PDT
Created attachment 201437 [details]
Patch

Proposed patch.
Comment 5 Dave Hyatt 2013-05-15 12:20:13 PDT
Comment on attachment 201437 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2013-05-15 15:58:46 PDT
Comment on attachment 201437 [details]
Patch

Clearing flags on attachment: 201437

Committed r150155: <http://trac.webkit.org/changeset/150155>
Comment 7 WebKit Commit Bot 2013-05-15 15:58:49 PDT
All reviewed patches have been landed.  Closing bug.