Bug 86518 – Change ascents and descent back to ints for now

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Emil A Eklund]

Change ascents and descent calculation back to integers for now. 

As it looks like we'll need to support both the 1/60 and 1/1 implementations of FractionalLayoutUnit for the immediate future to ensure that text is rendered at the same offset and with the height regardless of the ENABLE_SUBPIXEL_LAYOUT flag. This ensures that most websites will look the same at 100% zoom regardless of the flag and also allows us to the same test expectations for the vast majority of layout tests.

Eventually we want to move those back to FractionalLayoutUnits as that will result in more correct rendering.

[Emil A Eklund]

Created attachment 142047 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 142047 [details]
Patch

LGTM.

[Emil A Eklund]

Created attachment 142051 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 142051 [details]
Patch for landing

Rejecting attachment 142051 [details] from commit-queue.

New failing tests:
fast/block/float/overhanging-tall-block.html
Full output: http://queues.webkit.org/results/12701649

[WebKit Review Bot]

Created attachment 142110 [details]
Archive of layout-test-results from ec2-cq-02

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Emil A Eklund]

(In reply to comment #4)
> (From update of attachment 142051 [details])
> Rejecting attachment 142051 [details] from commit-queue.
> 
> New failing tests:
> fast/block/float/overhanging-tall-block.html
> Full output: http://queues.webkit.org/results/12701649

Needs rebaselining as expected. Will commit and rebaseline tomorrow.

[Emil A Eklund]

Committed r117310: <http://trac.webkit.org/changeset/117310>