WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
86518
Change ascents and descent back to ints for now
https://bugs.webkit.org/show_bug.cgi?id=86518
Summary
Change ascents and descent back to ints for now
Emil A Eklund
Reported
2012-05-15 13:36:24 PDT
Change ascents and descent calculation back to integers for now. As it looks like we'll need to support both the 1/60 and 1/1 implementations of FractionalLayoutUnit for the immediate future to ensure that text is rendered at the same offset and with the height regardless of the ENABLE_SUBPIXEL_LAYOUT flag. This ensures that most websites will look the same at 100% zoom regardless of the flag and also allows us to the same test expectations for the vast majority of layout tests. Eventually we want to move those back to FractionalLayoutUnits as that will result in more correct rendering.
Attachments
Patch
(8.02 KB, patch)
2012-05-15 13:55 PDT
,
Emil A Eklund
no flags
Details
Formatted Diff
Diff
Patch for landing
(7.53 KB, patch)
2012-05-15 14:16 PDT
,
Emil A Eklund
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ec2-cq-02
(731.89 KB, application/zip)
2012-05-15 17:40 PDT
,
WebKit Review Bot
no flags
Details
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Emil A Eklund
Comment 1
2012-05-15 13:55:31 PDT
Created
attachment 142047
[details]
Patch
Eric Seidel (no email)
Comment 2
2012-05-15 13:59:40 PDT
Comment on
attachment 142047
[details]
Patch LGTM.
Emil A Eklund
Comment 3
2012-05-15 14:16:11 PDT
Created
attachment 142051
[details]
Patch for landing
WebKit Review Bot
Comment 4
2012-05-15 17:40:48 PDT
Comment on
attachment 142051
[details]
Patch for landing Rejecting
attachment 142051
[details]
from commit-queue. New failing tests: fast/block/float/overhanging-tall-block.html Full output:
http://queues.webkit.org/results/12701649
WebKit Review Bot
Comment 5
2012-05-15 17:40:52 PDT
Created
attachment 142110
[details]
Archive of layout-test-results from ec2-cq-02 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: ec2-cq-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Emil A Eklund
Comment 6
2012-05-15 17:50:01 PDT
(In reply to
comment #4
)
> (From update of
attachment 142051
[details]
) > Rejecting
attachment 142051
[details]
from commit-queue. > > New failing tests: > fast/block/float/overhanging-tall-block.html > Full output:
http://queues.webkit.org/results/12701649
Needs rebaselining as expected. Will commit and rebaseline tomorrow.
Emil A Eklund
Comment 7
2012-05-16 11:29:17 PDT
Committed
r117310
: <
http://trac.webkit.org/changeset/117310
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug