Bug 86509 - Add support for private names
: Add support for private names
Status: RESOLVED FIXED
: WebKit
JavaScriptCore
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-05-15 12:30 PST by
Modified: 2012-05-28 14:25 PST (History)


Attachments
Fix (132.87 KB, patch)
2012-05-15 12:46 PST, Gavin Barraclough
oliver: review+
webkit-ews: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Add tests, fix style & Qt. (136.29 KB, patch)
2012-05-15 13:40 PST, Gavin Barraclough
webkit-ews: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-03 (791.80 KB, application/zip)
2012-05-15 15:16 PST, WebKit Review Bot
no flags Details
More Qt fixes (139.56 KB, patch)
2012-05-15 15:32 PST, Gavin Barraclough
webkit-ews: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
More Qt fixes (137.86 KB, patch)
2012-05-15 18:53 PST, Gavin Barraclough
webkit.review.bot: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-02 (753.38 KB, application/zip)
2012-05-16 00:53 PST, WebKit Review Bot
no flags Details
Archive of layout-test-results from ec2-cr-linux-03 (858.30 KB, application/zip)
2012-05-16 02:03 PST, WebKit Review Bot
no flags Details
Skip test on chrome (138.99 KB, patch)
2012-05-21 15:03 PST, Gavin Barraclough
webkit.review.bot: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-03 (682.77 KB, application/zip)
2012-05-21 16:56 PST, WebKit Review Bot
no flags Details


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-05-15 12:30:02 PST
The spec isn't final, but we can start adding support for property maps to contain keys that aren't identifiers.
------- Comment #1 From 2012-05-15 12:46:40 PST -------
Created an attachment (id=142034) [details]
Fix

No performance impact.
------- Comment #2 From 2012-05-15 12:50:01 PST -------
Attachment 142034 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/JavaScriptCore/interpreter/Interpreter.cpp:49:  Alphabetical sorting problem.  [build/include_order] [4]
Source/JavaScriptCore/runtime/NameConstructor.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
Source/JavaScriptCore/jit/JITStubs.cpp:54:  Alphabetical sorting problem.  [build/include_order] [4]
Source/JavaScriptCore/runtime/JSGlobalObject.cpp:56:  Alphabetical sorting problem.  [build/include_order] [4]
Source/JavaScriptCore/runtime/JSGlobalObject.cpp:66:  Alphabetical sorting problem.  [build/include_order] [4]
Source/JavaScriptCore/dfg/DFGOperations.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
Source/JavaScriptCore/runtime/NameConstructor.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 7 in 62 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #3 From 2012-05-15 12:59:24 PST -------
(From update of attachment 142034 [details])
Add a test for for-in enumeration with a private name -- I couldn't see anything that would prevent optimised for-in from observing the private name.
------- Comment #4 From 2012-05-15 13:03:41 PST -------
(In reply to comment #3)
> (From update of attachment 142034 [details] [details])
> Add a test for for-in enumeration with a private name -- I couldn't see anything that would prevent optimised for-in from observing the private name.

Will do - cheers oliver.
------- Comment #5 From 2012-05-15 13:32:48 PST -------
(From update of attachment 142034 [details])
Attachment 142034 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12701562
------- Comment #6 From 2012-05-15 13:40:59 PST -------
Created an attachment (id=142043) [details]
Add tests, fix style & Qt.
------- Comment #7 From 2012-05-15 13:45:33 PST -------
(From update of attachment 142034 [details])
Attachment 142034 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12715033
------- Comment #8 From 2012-05-15 15:09:57 PST -------
(From update of attachment 142043 [details])
Attachment 142043 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12706433
------- Comment #9 From 2012-05-15 15:14:27 PST -------
(From update of attachment 142043 [details])
Attachment 142043 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12705561
------- Comment #10 From 2012-05-15 15:16:08 PST -------
(From update of attachment 142034 [details])
Attachment 142034 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12704561

New failing tests:
fast/js/names.html
------- Comment #11 From 2012-05-15 15:16:13 PST -------
Created an attachment (id=142075) [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
------- Comment #12 From 2012-05-15 15:32:33 PST -------
Created an attachment (id=142081) [details]
More Qt fixes
------- Comment #13 From 2012-05-15 16:28:58 PST -------
(From update of attachment 142081 [details])
Attachment 142081 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12703606
------- Comment #14 From 2012-05-15 18:53:24 PST -------
Created an attachment (id=142124) [details]
More Qt fixes
------- Comment #15 From 2012-05-16 00:53:06 PST -------
(From update of attachment 142124 [details])
Attachment 142124 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12694913

New failing tests:
fast/js/names.html
------- Comment #16 From 2012-05-16 00:53:11 PST -------
Created an attachment (id=142184) [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
------- Comment #17 From 2012-05-16 02:03:33 PST -------
(From update of attachment 142124 [details])
Attachment 142124 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12716169

New failing tests:
fast/js/names.html
------- Comment #18 From 2012-05-16 02:03:39 PST -------
Created an attachment (id=142199) [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
------- Comment #19 From 2012-05-21 15:03:15 PST -------
Created an attachment (id=143109) [details]
Skip test on chrome
------- Comment #20 From 2012-05-21 16:55:57 PST -------
(From update of attachment 143109 [details])
Attachment 143109 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12738616

New failing tests:
svg/custom/use-css-no-effect-on-shadow-tree.svg
------- Comment #21 From 2012-05-21 16:56:15 PST -------
Created an attachment (id=143137) [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
------- Comment #22 From 2012-05-21 17:36:53 PST -------
Fixed in r117859
------- Comment #23 From 2012-05-22 03:48:16 PST -------
After this patch, we are hitting an assertion on our EFL Debug Bot:

ASSERTION FAILED: inherits(&s_info)
Source/JavaScriptCore/runtime/NameInstance.h(63) : void JSC::NameInstance::finishCreation(JSC::JSGlobalData&)
1   0x7f4b7ae54dc0 JSC::NameInstance::finishCreation(JSC::JSGlobalData&)
2   0x7f4b7ae54d51 JSC::NameInstance::create(JSC::JSGlobalData&, JSC::Structure*, JSC::JSString*)
3   0x7f4b7ae54c7e
4   0x7f4b7ad6a786 cti_op_call_NotJSFunction
5   0x7f4b7ad65dad
6   0x7ffff37fcb90
------- Comment #24 From 2012-05-22 03:51:18 PST -------
(In reply to comment #23)
> After this patch, we are hitting an assertion on our EFL Debug Bot:
> 
> ASSERTION FAILED: inherits(&s_info)
> Source/JavaScriptCore/runtime/NameInstance.h(63) : void JSC::NameInstance::finishCreation(JSC::JSGlobalData&)
> 1   0x7f4b7ae54dc0 JSC::NameInstance::finishCreation(JSC::JSGlobalData&)
> 2   0x7f4b7ae54d51 JSC::NameInstance::create(JSC::JSGlobalData&, JSC::Structure*, JSC::JSString*)
> 3   0x7f4b7ae54c7e
> 4   0x7f4b7ad6a786 cti_op_call_NotJSFunction
> 5   0x7f4b7ad65dad
> 6   0x7ffff37fcb90

Forgot to mention the test: fast/js/names.html
------- Comment #25 From 2012-05-22 06:14:35 PST -------
Also fails on GTK:

http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug/r117861%20(33465)/fast/js/names-crash-log.txt

Ps.: I added this test to EFL test_expectations.