Bug 86499 - [Chromium] IndexedDB: Allow a default data directory to be specified for IDBFactory
Summary: [Chromium] IndexedDB: Allow a default data directory to be specified for IDBF...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-15 10:45 PDT by Joshua Bell
Modified: 2012-05-15 16:48 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.93 KB, patch)
2012-05-15 11:52 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-05-15 10:45:33 PDT 
[Chromium] IndexedDB: Allow a default data directory to be specified for IDBFactory
Comment 1 Joshua Bell 2012-05-15 11:52:52 PDT 
Created attachment 142018 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-15 11:56:29 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Joshua Bell 2012-05-15 11:59:16 PDT 
The corresponding Chromium changes will live in src/webkit/support/test_webkit_platform_support.{h,cc} - TestWebKitPlatformSupport will have a ScopedTempDir and pass it through to WebIDBFactory::create in TestWebKitPlatformSupport::idbFactory
Comment 4 Joshua Bell 2012-05-15 12:15:42 PDT 
Chromium side is: https://chromiumcodereview.appspot.com/10382180
Comment 5 David Grogan 2012-05-15 14:38:08 PDT 
LGTM
Comment 6 Joshua Bell 2012-05-15 16:36:13 PDT 
Updated patches to https://chromiumcodereview.appspot.com/10382180 can do this w/o a WebKit API change, which is preferable.
Comment 7 James Robinson 2012-05-15 16:48:52 PDT 
Comment on attachment 142018 [details]
Patch

Clearing review? flag to remove this from webkit.org/pending-review