SVGElement::addEventListener has peculiar RefPtr usage
Created attachment 141996 [details] Patch
Comment on attachment 141996 [details] Patch Attachment 141996 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12684878
Comment on attachment 141996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141996&action=review > Source/WebCore/svg/SVGElement.cpp:371 > return Node::addEventListener(eventType, listener, useCapture); As the EFL bot says, listener is used here > Source/WebCore/svg/SVGElement.cpp:373 > + RefPtr<EventListener> listener = prpListener; ...but isn't declared until here.
EWS, not EFL
Comment on attachment 141996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141996&action=review >> Source/WebCore/svg/SVGElement.cpp:373 >> + RefPtr<EventListener> listener = prpListener; > > ...but isn't declared until here. Oops. Just need to move that up a few lines and say listener.release(). I’ll do that next time I’m at a computer with a source tree.
Created attachment 143462 [details] Patch
Comment on attachment 143462 [details] Patch Clearing flags on attachment: 143462 Committed r118393: <http://trac.webkit.org/changeset/118393>
All reviewed patches have been landed. Closing bug.