RESOLVED FIXED86482
Adding some already implemented features to FeatureSet in DOMImplementation 
https://bugs.webkit.org/show_bug.cgi?id=86482
Summary Adding some already implemented features to FeatureSet in DOMImplementation
Renata Hodovan
Reported 2012-05-15 07:02:07 PDT
There are some implemented features commented out in DOMImplementation::isSVG10Feature. So they won't be added to the feature set.
Attachments
Proposed patch (2.75 KB, patch)
2012-05-15 07:04 PDT, Renata Hodovan 		zimmermann: review-
rhodovan.u-szeged: commit-queue-
DetailsFormatted DiffDiff
Proposed patch (9.58 KB, patch)
2012-06-01 10:42 PDT, Renata Hodovan 		zimmermann: review+
rhodovan.u-szeged: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Renata Hodovan
Comment 1 2012-05-15 07:04:40 PDT
Created attachment 141959 [details] Proposed patch
Nikolas Zimmermann
Comment 2 2012-05-15 07:35:46 PDT
Comment on attachment 141959 [details] Proposed patch We need a new testcase demonstrating that these are enabled now :-)
Renata Hodovan
Comment 3 2012-05-31 02:49:05 PDT
(In reply to comment #2) > (From update of attachment 141959 [details]) > We need a new testcase demonstrating that these are enabled now :-) There are already tests added what check these features. E.g: svg/text/text-altglyph-01-b.svg for the text or svg/custom/linking-uri-01-b.svg for the view feature. Isn't enough to mention these test cases in the changelog? Should I combine them into a new common test?
Nikolas Zimmermann
Comment 4 2012-05-31 03:25:48 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 141959 [details] [details]) > > We need a new testcase demonstrating that these are enabled now :-) > > There are already tests added what check these features. E.g: svg/text/text-altglyph-01-b.svg for the text or svg/custom/linking-uri-01-b.svg for the view feature. Isn't enough to mention these test cases in the changelog? Should I combine them into a new common test? Nah, I meant a testcase that queries those features via the DOMImplementation interface, to proof we actually return true now :-)
Renata Hodovan
Comment 5 2012-06-01 10:42:13 PDT
Created attachment 145338 [details] Proposed patch I haven't add new testcase because we already have one for the same purpose (svg/custom/svg-features.html). I just had to update its expected.
Renata Hodovan
Comment 6 2012-06-07 08:24:25 PDT
Do we need anything else? :)
Nikolas Zimmermann
Comment 7 2012-06-07 22:53:50 PDT
Comment on attachment 145338 [details] Proposed patch Ah excellent, thanks reni! r=me! Next time ping more often, this took way too long to review :-)
Renata Hodovan
Comment 8 2012-06-08 08:20:50 PDT
Committed r119833: <http://trac.webkit.org/changeset/119833>
Note You need to log in before you can comment on or make changes to this bug.