There are some implemented features commented out in DOMImplementation::isSVG10Feature. So they won't be added to the feature set.
Created attachment 141959 [details] Proposed patch
Comment on attachment 141959 [details] Proposed patch We need a new testcase demonstrating that these are enabled now :-)
(In reply to comment #2) > (From update of attachment 141959 [details]) > We need a new testcase demonstrating that these are enabled now :-) There are already tests added what check these features. E.g: svg/text/text-altglyph-01-b.svg for the text or svg/custom/linking-uri-01-b.svg for the view feature. Isn't enough to mention these test cases in the changelog? Should I combine them into a new common test?
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 141959 [details] [details]) > > We need a new testcase demonstrating that these are enabled now :-) > > There are already tests added what check these features. E.g: svg/text/text-altglyph-01-b.svg for the text or svg/custom/linking-uri-01-b.svg for the view feature. Isn't enough to mention these test cases in the changelog? Should I combine them into a new common test? Nah, I meant a testcase that queries those features via the DOMImplementation interface, to proof we actually return true now :-)
Created attachment 145338 [details] Proposed patch I haven't add new testcase because we already have one for the same purpose (svg/custom/svg-features.html). I just had to update its expected.
Do we need anything else? :)
Comment on attachment 145338 [details] Proposed patch Ah excellent, thanks reni! r=me! Next time ping more often, this took way too long to review :-)
Committed r119833: <http://trac.webkit.org/changeset/119833>