Bug 86477 – Web Inspector: Refactor SnippetsModel: extract SnippetStorage, make SnippetScriptMapping delegate calls to ScriptSnippetModel and provide public interface on ScriptSnippetModel in terms of uiSourceCodes

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Vsevolod Vlasov]

Refactor SnippetsModel: extract SnippetStorage, make SnippetScriptMapping delegate calls to ScriptSnippetModel and provide public interface on ScriptSnippetModel in terms of uiSourceCodes

[Vsevolod Vlasov]

Created attachment 141950 [details]
Patch

[Pavel Feldman]

Comment on attachment 141950 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141950&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:-44
> -    this._mappings.push(this._snippetsMapping);

Now that DPM is only instantiating mappings, I don't see a problem in its dependency on snippets model.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:106
> +    set snippetMapping(snippetMapping)

Setters do not work great with the compiler, avoid their use.

> Source/WebCore/inspector/front-end/ScriptSnippetModel.js:75
> +        var uiSourceCode = new WebInspector.JavaScriptSource(uiSourceCodeURL, new WebInspector.SnippetContentProvider(snippet), this._snippetScriptMapping);

could snippet implement ContentProvider ?

> Source/WebCore/inspector/front-end/ScriptSnippetModel.js:89
> +        var snippet = this._snippetForUISourceCode.get(uiSourceCode);

I don't think one can follow consistency of these maps.

[Vsevolod Vlasov]

Committed r117065: <http://trac.webkit.org/changeset/117065>