Bug 86469 - Web Inspector: merge show navigator with pin navigator buttons.
Summary: Web Inspector: merge show navigator with pin navigator buttons.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-15 05:09 PDT by Pavel Feldman
Modified: 2012-05-15 05:49 PDT (History)
10 users (show)

See Also:

Attachments
[IMAGE] hidden (22.27 KB, image/png)
2012-05-15 05:12 PDT, Pavel Feldman 		no flags Details
[IMAGE] pinned (28.93 KB, image/png)
2012-05-15 05:12 PDT, Pavel Feldman 		no flags Details
[IMAGE] floating (39.85 KB, image/png)
2012-05-15 05:13 PDT, Pavel Feldman 		no flags Details
Patch (17.48 KB, patch)
2012-05-15 05:15 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (18.93 KB, patch)
2012-05-15 05:34 PDT, Pavel Feldman 		vsevik: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-05-15 05:09:09 PDT 
Small UI refactoring.
Comment 1 Pavel Feldman 2012-05-15 05:12:28 PDT 
Created attachment 141926 [details]
[IMAGE] hidden
Comment 2 Pavel Feldman 2012-05-15 05:12:44 PDT 
Created attachment 141927 [details]
[IMAGE] pinned
Comment 3 Pavel Feldman 2012-05-15 05:13:03 PDT 
Created attachment 141928 [details]
[IMAGE] floating
Comment 4 Pavel Feldman 2012-05-15 05:15:07 PDT 
Created attachment 141929 [details]
Patch
Comment 5 Vsevolod Vlasov 2012-05-15 05:29:41 PDT 
Comment on attachment 141929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141929&action=review

> Source/WebCore/inspector/front-end/NavigatorOverlayController.js:102
>      _pinNavigator: function()

You sohuld unregister shortcut and remove mouse down listener here.
Comment 6 Pavel Feldman 2012-05-15 05:34:54 PDT 
Created attachment 141932 [details]
Patch
Comment 7 Pavel Feldman 2012-05-15 05:49:17 PDT 
Committed r117055: <http://trac.webkit.org/changeset/117055>