RESOLVED FIXED86466
Web Inspector: AdvancedSearchController is not stopped then view is hidden. 
https://bugs.webkit.org/show_bug.cgi?id=86466
Summary Web Inspector: AdvancedSearchController is not stopped then view is hidden.
eustas.bug
Reported 2012-05-15 04:48:23 PDT
AdvancedSearchController overrides "wasHidden" method instead on "willHide".
Attachments
Patch (1.48 KB, patch)
2012-05-15 04:53 PDT, eustas.bug 		vsevik: review+
DetailsFormatted DiffDiff
Patch (1.48 KB, patch)
2012-05-15 06:27 PDT, eustas.bug 		no flags
DetailsFormatted DiffDiff
Patch (1.42 KB, patch)
2012-05-15 07:35 PDT, eustas.bug 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
eustas.bug
Comment 1 2012-05-15 04:53:36 PDT
Created attachment 141918 [details] Patch
Vsevolod Vlasov
Comment 2 2012-05-15 05:13:44 PDT
Comment on attachment 141918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141918&action=review > Source/WebCore/ChangeLog:6 > + AdvancedSearchController overrides "wasHidden" method instead of "willHide". Please move this line below "Reviewed by". > Source/WebCore/inspector/front-end/AdvancedSearchController.js:360 > + * @override We don't use @overrride annotation because it does not catch any error (try renaming back to wasHidden and observe no compiler errors).
eustas.bug
Comment 3 2012-05-15 06:15:57 PDT
Comment on attachment 141918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141918&action=review >> Source/WebCore/inspector/front-end/AdvancedSearchController.js:360 >> + * @override > > We don't use @overrride annotation because it does not catch any error (try renaming back to wasHidden and observe no compiler errors). I've tried it before writing this annotation. Compiler doesn't catch this error, that's no good. But we can hope it will do some day. BUT this annotation not only for compiler, but also for developers, because it make code a way core clear.
eustas.bug
Comment 4 2012-05-15 06:20:12 PDT
Comment on attachment 141918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141918&action=review >> Source/WebCore/ChangeLog:6 >> + AdvancedSearchController overrides "wasHidden" method instead of "willHide". > > Please move this line below "Reviewed by". OK
eustas.bug
Comment 5 2012-05-15 06:27:52 PDT
Created attachment 141948 [details] Patch
Vsevolod Vlasov
Comment 6 2012-05-15 06:45:25 PDT
Comment on attachment 141918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141918&action=review >>> Source/WebCore/inspector/front-end/AdvancedSearchController.js:360 >>> + * @override >> >> We don't use @overrride annotation because it does not catch any error (try renaming back to wasHidden and observe no compiler errors). > > I've tried it before writing this annotation. > Compiler doesn't catch this error, that's no good. But we can hope it will do some day. > > BUT this annotation not only for compiler, but also for developers, because it make code a way core clear. I don't think we should add compiler annotations for developers. We don't even add comments usually. Please remove this for consistency.
eustas.bug
Comment 7 2012-05-15 07:35:20 PDT
Created attachment 141966 [details] Patch
WebKit Review Bot
Comment 8 2012-05-15 09:12:21 PDT
Comment on attachment 141966 [details] Patch Clearing flags on attachment: 141966 Committed r117080: <http://trac.webkit.org/changeset/117080>
WebKit Review Bot
Comment 9 2012-05-15 09:12:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.