Bug 86462 - [EFL] The EFL port has no support for title directionality
Summary: [EFL] The EFL port has no support for title directionality
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 86475
  Show dependency tree / graph
 
Reported: 2012-05-15 04:12 PDT by Chris Dumez
Modified: 2012-05-24 00:02 PDT (History)
5 users (show)

See Also:

Attachments
Patch (16.50 KB, patch)
2012-05-15 06:11 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (15.18 KB, patch)
2012-05-15 22:54 PDT, Chris Dumez 		gustavo: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (15.72 KB, patch)
2012-05-23 23:00 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-05-15 04:12:55 PDT 
The EFL port has no support for title directionality which is needed by:
  fast/dom/title-directionality.html
  fast/dom/title-directionality-removeChild.html
Comment 1 Chris Dumez 2012-05-15 06:11:54 PDT 
Created attachment 141942 [details]
Patch

This patch adds title text direction support to EFL port.

Note however that the tests cannot be unskipped yet because the title direction is not yet exposed via LayoutTestController.titleTextDirection.
I will implement this in a second patch to avoid ending up with a huge patch.
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-05-15 10:29:42 PDT 
Comment on attachment 141942 [details]
Patch

Looks good to me, but your Tools/ChangeLog is borked (it contains an extra entry below yours).
Comment 3 Gyuyoung Kim 2012-05-15 18:52:52 PDT 
Comment on attachment 141942 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141942&action=review

As kubo, this patch looks good to me except for trivial style nit.

> Source/WebKit/efl/ewk/ewk_frame.h:155
> +    EWK_TEXT_DIRECTION_DEFAULT, // Natural writing direction ("inherit")

Style nit : We are using /**< instead of // in public header files.
Comment 4 Chris Dumez 2012-05-15 22:54:49 PDT 
Created attachment 142157 [details]
Patch

Take feedback into consideration.
Comment 5 WebKit Review Bot 2012-05-23 07:47:14 PDT 
Comment on attachment 142157 [details]
Patch

Rejecting attachment 142157 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
enderTree/efl/DumpRenderTreeChrome.cpp
Hunk #1 FAILED at 436.
1 out of 1 hunk FAILED -- saving rejects to file Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp.rej
patching file Tools/EWebLauncher/main.c
Hunk #1 succeeded at 229 (offset 3 lines).
Hunk #2 succeeded at 256 (offset 3 lines).
Hunk #3 succeeded at 492 (offset 3 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Gustavo No..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12768230
Comment 6 Chris Dumez 2012-05-23 23:00:36 PDT 
Created attachment 143737 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-05-24 00:02:30 PDT 
Comment on attachment 143737 [details]
Patch for landing

Clearing flags on attachment: 143737

Committed r118329: <http://trac.webkit.org/changeset/118329>
Comment 8 WebKit Review Bot 2012-05-24 00:02:35 PDT 
All reviewed patches have been landed.  Closing bug.