Bug 86460 – [EFL][DRT] LayoutTestController does not implement applicationCacheDiskUsageForOrigin

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit EFL

[Jussi Kukkonen (jku)]

EFL's LayoutTestController should implement applicationCacheDiskUsageForOrigin() so we can unskip http/tests/appcache/origin-usage.html.

[Jussi Kukkonen (jku)]

Created attachment 142206 [details]
Patch

This will not yet compile without patch in bug 86195, marking 'no-review' for now.

[Gyuyoung Kim]

Comment on attachment 142206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142206&action=review

Almost looks good to me except for a style nit.

> Source/WebKit/efl/ewk/ewk_security_origin.cpp:89
> +uint64_t ewk_security_origin_application_cache_usage_get(const Ewk_Security_Origin *origin)

Move '*' operator to data type side.

[Chris Dumez]

Comment on attachment 142206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142206&action=review

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:577
> +    long long usage = ewk_security_origin_application_cache_usage_get(securityOrigin);

Could be marked as const.

[Jussi Kukkonen (jku)]

Created attachment 145550 [details]
Patch

[Jussi Kukkonen (jku)]

(In reply to comment #4)
> Created an attachment (id=145550) [details]
> Patch

Fixes issues from comment 2 and comment 3, rebases to current master.

[Chris Dumez]

Comment on attachment 145550 [details]
Patch

LGTM.

[Gyuyoung Kim]

Comment on attachment 145550 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145550&action=review

> LayoutTests/platform/efl/Skipped:-168
> -# EFL's LayoutTestController does not implement applicationCacheDiskUsageForOrigin

Now we moved this to TestExpectations file. If this patch is still valid, please touch the file.

# EFL's TestRunner does not implement applicationCacheDiskUsageForOrigin
webkit.org/b/86460 http/tests/appcache/origin-usage.html [ Failure ]

[Michael Catanzaro]

Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.