Bug 86459 - MediaStream API: Setting onended on a LocalMediaStream triggers an assertion in V8
Summary: MediaStream API: Setting onended on a LocalMediaStream triggers an assertion ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks: 56459
  Show dependency treegraph
 
Reported: 2012-05-15 03:11 PDT by Tommy Widenflycht
Modified: 2012-05-15 11:15 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.26 KB, patch)
2012-05-15 03:15 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-05-15 03:11:34 PDT
Setting onended on a MediaStream (either remote or created) works just fine.

LocalMediaStream inherits from MediaStream, but only MediaStream have the EventTarget idl attribute. Adding the attribute to LocalMediaStream as well fixes the issue.
Comment 1 Tommy Widenflycht 2012-05-15 03:15:45 PDT
Created attachment 141907 [details]
Patch
Comment 2 Adam Barth 2012-05-15 10:32:01 PDT
Comment on attachment 141907 [details]
Patch

Yeah, it's lame that we don't inherit these sorts of attributes.
Comment 3 WebKit Review Bot 2012-05-15 11:14:59 PDT
Comment on attachment 141907 [details]
Patch

Clearing flags on attachment: 141907

Committed r117102: <http://trac.webkit.org/changeset/117102>
Comment 4 WebKit Review Bot 2012-05-15 11:15:05 PDT
All reviewed patches have been landed.  Closing bug.