Bug 86456 - [EFL] WebKit style should apply to all ewk files but public headers
Summary: [EFL] WebKit style should apply to all ewk files but public headers
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on: 84572 85178
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-15 02:36 PDT by Thiago Marcos P. Santos
Modified: 2012-05-16 05:25 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-05-15 02:36:58 PDT
My preliminary investigation tells that we need to update the port specific rules on checker.py and move the public headers to another folder.
Comment 1 Raphael Kubo da Costa (:rakuco) 2012-05-15 13:20:20 PDT
Or just add enough logic to the checker to skip some style checks for public headers?
Comment 2 Thiago Marcos P. Santos 2012-05-15 14:59:42 PDT
(In reply to comment #1)
> Or just add enough logic to the checker to skip some style checks for public headers?

IMO it would need regex support when matching files. I'm going to evaluate tomorrow to check if it's not overkill.
Comment 3 Thiago Marcos P. Santos 2012-05-16 05:25:42 PDT
"readability/naming" cannot be enabled for ewk/. Even if enable only for the .cpp files, it will still complain about the function names. IMO not much can be done.