WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
86456
[EFL] WebKit style should apply to all ewk files but public headers
https://bugs.webkit.org/show_bug.cgi?id=86456
Summary
[EFL] WebKit style should apply to all ewk files but public headers
Thiago Marcos P. Santos
Reported
2012-05-15 02:36:58 PDT
My preliminary investigation tells that we need to update the port specific rules on checker.py and move the public headers to another folder.
Attachments
Add attachment
proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1
2012-05-15 13:20:20 PDT
Or just add enough logic to the checker to skip some style checks for public headers?
Thiago Marcos P. Santos
Comment 2
2012-05-15 14:59:42 PDT
(In reply to
comment #1
)
> Or just add enough logic to the checker to skip some style checks for public headers?
IMO it would need regex support when matching files. I'm going to evaluate tomorrow to check if it's not overkill.
Thiago Marcos P. Santos
Comment 3
2012-05-16 05:25:42 PDT
"readability/naming" cannot be enabled for ewk/. Even if enable only for the .cpp files, it will still complain about the function names. IMO not much can be done.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug