Bug 86455 – Web Inspector: implement "Reveal in Dominators view" context menu action

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

We already have an action for revealing a JS object in the Summary view in heap profiler. It is logical to have similar option for the Dominators view.

[Yury Semikhatsky]

Created attachment 141898 [details]
Patch

[Ilya Tikhonovsky]

Comment on attachment 141898 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141898&action=review

> Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:198
> +                    insertShowMoreButton.call(this, 0, items.startPosition, insertionIndex++);

why this line was changed

> Source/WebCore/inspector/front-end/ProfilesPanel.js:1100
> +        function revealInSummaryView(viewName)

please rename the function: function revealIn(viewName)

[Yury Semikhatsky]

(In reply to comment #2)
> (From update of attachment 141898 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141898&action=review
> 
> > Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:198
> > +                    insertShowMoreButton.call(this, 0, items.startPosition, insertionIndex++);
> 
> why this line was changed
> 
There was a bug and the new test has caught it.

> > Source/WebCore/inspector/front-end/ProfilesPanel.js:1100
> > +        function revealInSummaryView(viewName)
> 
> please rename the function: function revealIn(viewName)
Done.

[Yury Semikhatsky]

Created attachment 141911 [details]
Patch

[Pavel Feldman]

Comment on attachment 141911 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141911&action=review

> Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js:665
> +                WebInspector.log("Cannot find the node");

Either localize user message or remove debug output.

[Yury Semikhatsky]

(In reply to comment #5)
> (From update of attachment 141911 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141911&action=review
> 
> > Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js:665
> > +                WebInspector.log("Cannot find the node");
> 
> Either localize user message or remove debug output.

Added to localizedStrings.js

[Yury Semikhatsky]

Committed r117051: <http://trac.webkit.org/changeset/117051>