RESOLVED FIXED 86455
Web Inspector: implement "Reveal in Dominators view" context menu action
https://bugs.webkit.org/show_bug.cgi?id=86455
Summary Web Inspector: implement "Reveal in Dominators view" context menu action
Yury Semikhatsky
Reported 2012-05-15 02:00:22 PDT
We already have an action for revealing a JS object in the Summary view in heap profiler. It is logical to have similar option for the Dominators view.
Attachments
Patch (22.08 KB, patch)
2012-05-15 02:20 PDT, Yury Semikhatsky
no flags
Patch (22.06 KB, patch)
2012-05-15 03:57 PDT, Yury Semikhatsky
pfeldman: review+
Yury Semikhatsky
Comment 1 2012-05-15 02:20:52 PDT
Ilya Tikhonovsky
Comment 2 2012-05-15 02:39:51 PDT
Comment on attachment 141898 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141898&action=review > Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:198 > + insertShowMoreButton.call(this, 0, items.startPosition, insertionIndex++); why this line was changed > Source/WebCore/inspector/front-end/ProfilesPanel.js:1100 > + function revealInSummaryView(viewName) please rename the function: function revealIn(viewName)
Yury Semikhatsky
Comment 3 2012-05-15 03:56:56 PDT
(In reply to comment #2) > (From update of attachment 141898 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=141898&action=review > > > Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:198 > > + insertShowMoreButton.call(this, 0, items.startPosition, insertionIndex++); > > why this line was changed > There was a bug and the new test has caught it. > > Source/WebCore/inspector/front-end/ProfilesPanel.js:1100 > > + function revealInSummaryView(viewName) > > please rename the function: function revealIn(viewName) Done.
Yury Semikhatsky
Comment 4 2012-05-15 03:57:37 PDT
Pavel Feldman
Comment 5 2012-05-15 04:08:13 PDT
Comment on attachment 141911 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141911&action=review > Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js:665 > + WebInspector.log("Cannot find the node"); Either localize user message or remove debug output.
Yury Semikhatsky
Comment 6 2012-05-15 04:14:06 PDT
(In reply to comment #5) > (From update of attachment 141911 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=141911&action=review > > > Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js:665 > > + WebInspector.log("Cannot find the node"); > > Either localize user message or remove debug output. Added to localizedStrings.js
Yury Semikhatsky
Comment 7 2012-05-15 04:17:26 PDT
Note You need to log in before you can comment on or make changes to this bug.