Bug 86455 - Web Inspector: implement "Reveal in Dominators view" context menu action
Summary: Web Inspector: implement "Reveal in Dominators view" context menu action
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-15 02:00 PDT by Yury Semikhatsky
Modified: 2012-05-15 04:17 PDT (History)
11 users (show)

See Also:

Attachments
Patch (22.08 KB, patch)
2012-05-15 02:20 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (22.06 KB, patch)
2012-05-15 03:57 PDT, Yury Semikhatsky 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-05-15 02:00:22 PDT 
We already have an action for revealing a JS object in the Summary view in heap profiler. It is logical to have similar option for the Dominators view.
Comment 1 Yury Semikhatsky 2012-05-15 02:20:52 PDT 
Created attachment 141898 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-05-15 02:39:51 PDT 
Comment on attachment 141898 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141898&action=review

> Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:198
> +                    insertShowMoreButton.call(this, 0, items.startPosition, insertionIndex++);

why this line was changed

> Source/WebCore/inspector/front-end/ProfilesPanel.js:1100
> +        function revealInSummaryView(viewName)

please rename the function: function revealIn(viewName)
Comment 3 Yury Semikhatsky 2012-05-15 03:56:56 PDT 
(In reply to comment #2)
> (From update of attachment 141898 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141898&action=review
> 
> > Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:198
> > +                    insertShowMoreButton.call(this, 0, items.startPosition, insertionIndex++);
> 
> why this line was changed
> 
There was a bug and the new test has caught it.

> > Source/WebCore/inspector/front-end/ProfilesPanel.js:1100
> > +        function revealInSummaryView(viewName)
> 
> please rename the function: function revealIn(viewName)
Done.
Comment 4 Yury Semikhatsky 2012-05-15 03:57:37 PDT 
Created attachment 141911 [details]
Patch
Comment 5 Pavel Feldman 2012-05-15 04:08:13 PDT 
Comment on attachment 141911 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141911&action=review

> Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js:665
> +                WebInspector.log("Cannot find the node");

Either localize user message or remove debug output.
Comment 6 Yury Semikhatsky 2012-05-15 04:14:06 PDT 
(In reply to comment #5)
> (From update of attachment 141911 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141911&action=review
> 
> > Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js:665
> > +                WebInspector.log("Cannot find the node");
> 
> Either localize user message or remove debug output.

Added to localizedStrings.js
Comment 7 Yury Semikhatsky 2012-05-15 04:17:26 PDT 
Committed r117051: <http://trac.webkit.org/changeset/117051>