Created attachment 141854 [details] testcase http://www.w3.org/TR/css3-multicol/#overflow-inside-multicol-elements
Created attachment 141856 [details] Proposed Patch
Comment on attachment 141856 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141856&action=review > LayoutTests/fast/multicol/overflow-into-columngap-expected.html:1 > +<!DOCTYPE html> Some extra characters seen. Are these intentional characters? Also should the expected file be txt file or html file?
Comment on attachment 141856 [details] Proposed Patch Attachment 141856 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12681747 New failing tests: fast/borders/border-antialiasing.html fast/multicol/shadow-breaking.html fast/multicol/vertical-rl/border-padding-pagination.html fast/multicol/vertical-lr/border-padding-pagination.html
Created attachment 141875 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 141915 [details] Patch For checking EWS
Comment on attachment 141915 [details] Patch Attachment 141915 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12679910 New failing tests: fast/borders/border-antialiasing.html http/tests/security/sandboxed-iframe-origin-add.html fast/multicol/span/anonymous-split-block-crash.html fast/multicol/positive-leading.html fast/multicol/span/span-as-immediate-child-complex-splitting.html fast/loader/text-document-wrapping.html fast/multicol/span/anonymous-style-inheritance.html fast/multicol/vertical-rl/border-padding-pagination.html fast/multicol/span/span-as-immediate-child-generated-content.html fast/multicol/span/span-as-immediate-columns-child.html fast/multicol/span/span-as-nested-columns-child-dynamic.html fast/line-grid/line-grid-into-columns.html fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html fast/multicol/vertical-lr/column-rules.html fast/multicol/span/anonymous-before-child-parent-crash.html fast/canvas/webgl/shader-precision-format.html fast/multicol/span/span-as-immediate-columns-child-dynamic.html fast/multicol/span/generated-child-split-flow-crash.html fast/multicol/nested-columns.html fast/multicol/single-line.html fast/multicol/column-rules-stacking.html fast/multicol/vertical-lr/nested-columns.html fast/multicol/vertical-lr/border-padding-pagination.html fast/multicol/column-rules.html fast/multicol/overflow-unsplittable.html fast/multicol/shadow-breaking.html fast/loader/javascript-url-in-object.html fast/multicol/span/span-margin-collapsing.html fast/multicol/span/span-as-nested-columns-child.html http/tests/inspector/resource-har-pages.html
Created attachment 141917 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 142167 [details] Fixed testcase Fixed test case. Previously attached test case was about clipping content when overflow outside multi-column element. This test case is about overflowing into column-gap.
Created attachment 142179 [details] Patch with fixed testcase
Comment on attachment 142179 [details] Patch with fixed testcase Attachment 142179 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12718157 New failing tests: fast/borders/border-antialiasing.html fast/multicol/shadow-breaking.html
Created attachment 142222 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 142252 [details] Updated Patch Failing tests need to be rebased.
Created attachment 142410 [details] Rebased Patch
Seems reasonable, but should you be using LayoutUnits here instead?
Created attachment 142435 [details] Updated Patch Thanks for reviewing Eric. Adding Hyatt in cc for reviewing this multicolumn patch.
Created attachment 142437 [details] Rebased Patch
Comment on attachment 142437 [details] Rebased Patch Hopefully this will do the right thing. :)
Comment on attachment 142437 [details] Rebased Patch Clearing flags on attachment: 142437 Committed r117412: <http://trac.webkit.org/changeset/117412>
All reviewed patches have been landed. Closing bug.
<rdar://problem/11520511>