Bug 86429 - RenderLayer::repaintRectIncludingDescendants shouldn't include repaint rects of composited descendants
Summary: RenderLayer::repaintRectIncludingDescendants shouldn't include repaint rects ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-05-14 19:12 PDT by Tim Horton
Modified: 2012-05-14 23:11 PDT (History)
3 users (show)

See Also:

Attachments
patch (3.48 KB, patch)
2012-05-14 19:56 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2012-05-14 19:12:08 PDT 
As it stands, we can end up unioning a rect with a page-relative origin and a rect with a 0,0 origin (the compositing layer), creating huge repaint rects with some content. Composited descendants don't need to be factored in here (the only use of repaintRectIncludingDescendants is in scrollContentsFathPath, and composited layers won't need to be invalidated manually there).

This is a significant scrolling performance win on some pages.

<rdar://problem/11445132>
Comment 1 Tim Horton 2012-05-14 19:56:46 PDT 
Created attachment 141845 [details]
patch
Comment 2 Tim Horton 2012-05-14 23:11:37 PDT 
http://trac.webkit.org/changeset/117032