Bug 86418 - CSS3's vh attribute is not adjusting while browser resizes
Summary: CSS3's vh attribute is not adjusting while browser resizes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P3 Major
Assignee: Nobody
URL: http://jsfiddle.net/JamesKyle/sRYDC/
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-14 17:36 PDT by James Kyle
Modified: 2013-01-31 15:13 PST (History)
5 users (show)

See Also:


Attachments
Proposed patch (8.88 KB, patch)
2013-01-31 00:26 PST, Uday Kiran
no flags Details | Formatted Diff | Diff
Patch for landing (7.88 KB, patch)
2013-01-31 12:28 PST, Uday Kiran
no flags Details | Formatted Diff | Diff
Patch for landing (7.88 KB, patch)
2013-01-31 12:36 PST, Uday Kiran
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Kyle 2012-05-14 17:36:38 PDT
Tested on Google Chrome Canary (21.0.1136.0)

New CSS3 values vh & vw (viewport height & width) implemented in a way that only adjust when resizing the browser horizontally not vertically.

This needs further testing to prove its not just Chrome or JSfiddle.net causing the problem.
Comment 1 Uday Kiran 2013-01-31 00:26:19 PST
Created attachment 185703 [details]
Proposed patch
Comment 2 Antti Koivisto 2013-01-31 12:09:56 PST
Comment on attachment 185703 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185703&action=review

Looks good otherwise.

> Source/WebCore/ChangeLog:24
> +        (WebCore::RenderBoxModelObject::calculateFillTileSize): Fixed an error in
> +        initial implementation of vw/vh/vmin.

Please file a separate bug for this. You should fix it in a separate patch with a test case.
Comment 3 Uday Kiran 2013-01-31 12:28:09 PST
Created attachment 185837 [details]
Patch for landing
Comment 4 Uday Kiran 2013-01-31 12:36:05 PST
Created attachment 185839 [details]
Patch for landing
Comment 5 Uday Kiran 2013-01-31 12:38:10 PST
(In reply to comment #4)
> Created an attachment (id=185839) [details]
> Patch for landing

Used webkit-patch land-safely incorrectly, first time :) and missed reviewer's name.
Comment 6 WebKit Review Bot 2013-01-31 15:13:38 PST
Comment on attachment 185839 [details]
Patch for landing

Clearing flags on attachment: 185839

Committed r141492: <http://trac.webkit.org/changeset/141492>
Comment 7 WebKit Review Bot 2013-01-31 15:13:41 PST
All reviewed patches have been landed.  Closing bug.