Bug 86415 - [chromium] Prevent KeyCodeConversionAndroid from breaking on next NDK roll
Summary: [chromium] Prevent KeyCodeConversionAndroid from breaking on next NDK roll
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandre Elias
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-14 17:05 PDT by Alexandre Elias
Modified: 2012-05-14 18:10 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.81 KB, patch)
2012-05-14 17:08 PDT, Alexandre Elias
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Elias 2012-05-14 17:05:28 PDT
[chromium] Prevent KeyCodeConversionAndroid from breaking on next NDK roll
Comment 1 Alexandre Elias 2012-05-14 17:08:35 PDT
Created attachment 141818 [details]
Patch
Comment 2 Adam Barth 2012-05-14 17:10:31 PDT
Great!
Comment 3 WebKit Review Bot 2012-05-14 17:47:02 PDT
Comment on attachment 141818 [details]
Patch

Rejecting attachment 141818 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 directory at Tools/Scripts/update-webkit line 118.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2
   deps_parsed: True
    requirements: ('./',)

Error: 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees'
No such file or directory at Tools/Scripts/update-webkit line 118.

Full output: http://queues.webkit.org/results/12682541
Comment 4 Alexandre Elias 2012-05-14 17:56:46 PDT
Comment on attachment 141818 [details]
Patch

Looks like bot burp, setting cq? again.
Comment 5 Adam Barth 2012-05-14 18:09:55 PDT
Comment on attachment 141818 [details]
Patch

Clearing flags on attachment: 141818

Committed r117022: <http://trac.webkit.org/changeset/117022>
Comment 6 Adam Barth 2012-05-14 18:10:00 PDT
All reviewed patches have been landed.  Closing bug.