Bug 86402 - REGRESSION(r116981): Caused compositing and mathml tests to fail. (Requested by rakuco on #webkit).
Summary: REGRESSION(r116981): Caused compositing and mathml tests to fail. (Requested ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-14 14:18 PDT by WebKit Review Bot
Modified: 2012-05-14 14:28 PDT (History)
7 users (show)

See Also:


Attachments
ROLLOUT of r116981 (1.67 KB, patch)
2012-05-14 14:18 PDT, WebKit Review Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-05-14 14:18:00 PDT
http://trac.webkit.org/changeset/116981 broke the build:
Caused compositing and mathml tests to fail. (Requested by rakuco on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2012-05-14 14:18:52 PDT
Created attachment 141788 [details]
ROLLOUT of r116981

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-05-14 14:22:31 PDT
The patch in bug 86355 is correct, however it had the side-effect of causing a lot of compositing and mathml tests which were not being run because libwebcore_efl.so was not being found to actually run and fail.

I believe they are still correct and just need to be rebaselined after the recent font and jhbuild changes, but meanwhile it's safer to roll it out to keep the bot green.
Comment 3 WebKit Review Bot 2012-05-14 14:27:54 PDT
Comment on attachment 141788 [details]
ROLLOUT of r116981

Clearing flags on attachment: 141788

Committed r117003: <http://trac.webkit.org/changeset/117003>
Comment 4 WebKit Review Bot 2012-05-14 14:28:01 PDT
All reviewed patches have been landed.  Closing bug.