Bug 86399 - Convert CSS and Parser tests to runs/s tests
Summary: Convert CSS and Parser tests to runs/s tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 77037
  Show dependency tree / graph
 
Reported: 2012-05-14 13:59 PDT by Ryosuke Niwa
Modified: 2012-05-14 14:19 PDT (History)
7 users (show)

See Also:

Attachments
Converted CSS and Parser tests to use runPerSecond (5.02 KB, patch)
2012-05-14 14:00 PDT, Ryosuke Niwa 		ojan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-05-14 13:59:41 PDT 
Convert CSS and Parser tests to runs/s tests
Comment 1 Ryosuke Niwa 2012-05-14 14:00:39 PDT 
Created attachment 141785 [details]
Converted CSS and Parser tests to use runPerSecond
Comment 2 Eric Seidel (no email) 2012-05-14 14:05:47 PDT 
I don't understand what this change does.  Could you please explain more in teh ChangeLOg?
Comment 3 Ojan Vafai 2012-05-14 14:10:33 PDT 
Comment on attachment 141785 [details]
Converted CSS and Parser tests to use runPerSecond

r=me assuming you add a more descriptive changelog. IMO, reducing bot cycle time is the secondary benefit. The other advantage is that runPerSecond is less likely to degrade overtime as we improve performance on the test.
Comment 4 Ryosuke Niwa 2012-05-14 14:13:40 PDT 
(In reply to comment #2)
> I don't understand what this change does.  Could you please explain more in teh ChangeLOg?

Sorry I forgot to mention that this is a follow up to http://trac.webkit.org/changeset/116916.

Basically we want to measure performance in runs/s (i.e. function calls per second) instead of ms so that when WebKit gets faster, we can still measure it reliably (e.g. granularity of Date.now() appears to be around 10-50ms) without having to modify tests to make them artificially slower.
Comment 5 Ryosuke Niwa 2012-05-14 14:19:00 PDT 
Committed r117001: <http://trac.webkit.org/changeset/117001>