Bug 86394 - [BlackBerry] adding a functionality for web inspector to inspect current selected element
Summary: [BlackBerry] adding a functionality for web inspector to inspect current sele...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-14 13:03 PDT by Hanna
Modified: 2012-05-15 08:51 PDT (History)
4 users (show)

See Also:

Attachments
patch (2.56 KB, patch)
2012-05-14 14:22 PDT, Hanna 		rwlbuis: review-
Details | Formatted Diff | Diff
patch (2.70 KB, patch)
2012-05-14 14:59 PDT, Hanna 		rwlbuis: review-
Details | Formatted Diff | Diff
patch (2.68 KB, patch)
2012-05-15 06:56 PDT, Hanna 		no flags Details | Formatted Diff | Diff
patch (2.68 KB, patch)
2012-05-15 07:07 PDT, Hanna 		rwlbuis: review-
Details | Formatted Diff | Diff
patch (2.70 KB, patch)
2012-05-15 07:22 PDT, Hanna 		no flags Details | Formatted Diff | Diff
patch (2.70 KB, patch)
2012-05-15 07:24 PDT, Hanna 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hanna 2012-05-14 13:03:38 PDT 
adding a functionality for web inspector to inspect current selected element
Comment 1 Konrad Piascik 2012-05-14 13:22:27 PDT 
update summary, component.
Comment 2 Hanna 2012-05-14 14:22:09 PDT 
Created attachment 141789 [details]
patch
Comment 3 Rob Buis 2012-05-14 14:32:45 PDT 
Comment on attachment 141789 [details]
patch

Looks good, but ChangeLog needs a line to describe the change.
Comment 4 Hanna 2012-05-14 14:59:01 PDT 
Created attachment 141796 [details]
patch
Comment 5 Rob Buis 2012-05-14 15:07:56 PDT 
Comment on attachment 141796 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141796&action=review

Please fix ChangeLog problem.

> Source/WebKit/blackberry/ChangeLog:4
> +                     a way of remote tracking on selected items using web inspector

You need to leave this as before. So bug title on one line, bug url on next line.

> Source/WebKit/blackberry/ChangeLog:8
> +

The actual explanation should go here :)
Comment 6 Hanna 2012-05-15 06:56:29 PDT 
Created attachment 141957 [details]
patch
Comment 7 Konrad Piascik 2012-05-15 06:59:38 PDT 
Comment on attachment 141957 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141957&action=review

> Source/WebKit/blackberry/ChangeLog:8
> +	a way of remote tracking on selected items using web inspector

The indentation is off.  Also this isn't a complete sentence.  Maybe use "Added a away to call Inspect Element to remote web inspector."
Comment 8 Hanna 2012-05-15 07:07:41 PDT 
Created attachment 141961 [details]
patch
Comment 9 Rob Buis 2012-05-15 07:14:46 PDT 
Comment on attachment 141961 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141961&action=review

One more iteration needed.

> Source/WebKit/blackberry/ChangeLog:8
> +        a way to call Inspect Element to remote web inspector. 

I think you want to say "Add a way to call Inspect Element from the remote web inspector."
Comment 10 Hanna 2012-05-15 07:22:22 PDT 
Created attachment 141963 [details]
patch
Comment 11 Hanna 2012-05-15 07:24:40 PDT 
Created attachment 141964 [details]
patch
Comment 12 Rob Buis 2012-05-15 07:25:18 PDT 
Comment on attachment 141964 [details]
patch

Looks good!
Comment 13 WebKit Review Bot 2012-05-15 08:51:21 PDT 
Comment on attachment 141964 [details]
patch

Clearing flags on attachment: 141964

Committed r117078: <http://trac.webkit.org/changeset/117078>
Comment 14 WebKit Review Bot 2012-05-15 08:51:26 PDT 
All reviewed patches have been landed.  Closing bug.