RESOLVED FIXED Bug 86394
[BlackBerry] adding a functionality for web inspector to inspect current selected element 
https://bugs.webkit.org/show_bug.cgi?id=86394
Summary [BlackBerry] adding a functionality for web inspector to inspect current sele...
Hanna
Reported 2012-05-14 13:03:38 PDT
adding a functionality for web inspector to inspect current selected element
Attachments
patch (2.56 KB, patch)
2012-05-14 14:22 PDT, Hanna 		rwlbuis: review-
DetailsFormatted DiffDiff
patch (2.70 KB, patch)
2012-05-14 14:59 PDT, Hanna 		rwlbuis: review-
DetailsFormatted DiffDiff
patch (2.68 KB, patch)
2012-05-15 06:56 PDT, Hanna 		no flags
DetailsFormatted DiffDiff
patch (2.68 KB, patch)
2012-05-15 07:07 PDT, Hanna 		rwlbuis: review-
DetailsFormatted DiffDiff
patch (2.70 KB, patch)
2012-05-15 07:22 PDT, Hanna 		no flags
DetailsFormatted DiffDiff
patch (2.70 KB, patch)
2012-05-15 07:24 PDT, Hanna 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Konrad Piascik
Comment 1 2012-05-14 13:22:27 PDT
update summary, component.
Hanna
Comment 2 2012-05-14 14:22:09 PDT
Created attachment 141789 [details] patch
Rob Buis
Comment 3 2012-05-14 14:32:45 PDT
Comment on attachment 141789 [details] patch Looks good, but ChangeLog needs a line to describe the change.
Hanna
Comment 4 2012-05-14 14:59:01 PDT
Created attachment 141796 [details] patch
Rob Buis
Comment 5 2012-05-14 15:07:56 PDT
Comment on attachment 141796 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=141796&action=review Please fix ChangeLog problem. > Source/WebKit/blackberry/ChangeLog:4 > + a way of remote tracking on selected items using web inspector You need to leave this as before. So bug title on one line, bug url on next line. > Source/WebKit/blackberry/ChangeLog:8 > + The actual explanation should go here :)
Hanna
Comment 6 2012-05-15 06:56:29 PDT
Created attachment 141957 [details] patch
Konrad Piascik
Comment 7 2012-05-15 06:59:38 PDT
Comment on attachment 141957 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=141957&action=review > Source/WebKit/blackberry/ChangeLog:8 > + a way of remote tracking on selected items using web inspector The indentation is off. Also this isn't a complete sentence. Maybe use "Added a away to call Inspect Element to remote web inspector."
Hanna
Comment 8 2012-05-15 07:07:41 PDT
Created attachment 141961 [details] patch
Rob Buis
Comment 9 2012-05-15 07:14:46 PDT
Comment on attachment 141961 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=141961&action=review One more iteration needed. > Source/WebKit/blackberry/ChangeLog:8 > + a way to call Inspect Element to remote web inspector. I think you want to say "Add a way to call Inspect Element from the remote web inspector."
Hanna
Comment 10 2012-05-15 07:22:22 PDT
Created attachment 141963 [details] patch
Hanna
Comment 11 2012-05-15 07:24:40 PDT
Created attachment 141964 [details] patch
Rob Buis
Comment 12 2012-05-15 07:25:18 PDT
Comment on attachment 141964 [details] patch Looks good!
WebKit Review Bot
Comment 13 2012-05-15 08:51:21 PDT
Comment on attachment 141964 [details] patch Clearing flags on attachment: 141964 Committed r117078: <http://trac.webkit.org/changeset/117078>
WebKit Review Bot
Comment 14 2012-05-15 08:51:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.