Bug 86388 - Pagination splits lines that could fit on a single page if it were not for their top leading
Summary: Pagination splits lines that could fit on a single page if it were not for th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords: InRadar
Depends on: 86445
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-14 11:58 PDT by mitz
Modified: 2012-05-14 22:44 PDT (History)
4 users (show)

See Also:


Attachments
Make tall lines split in the top leading so that the visible content fits on a single page (5.45 KB, patch)
2012-05-14 12:04 PDT, mitz
darin: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-01 (839.97 KB, application/zip)
2012-05-14 12:43 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2012-05-14 11:58:39 PDT
Pagination splits lines that could fit on a single page if it were not for their top leading
Comment 1 mitz 2012-05-14 12:01:47 PDT
<rdar://problem/10288903>
Comment 2 mitz 2012-05-14 12:04:33 PDT
Created attachment 141764 [details]
Make tall lines split in the top leading so that the visible content fits on a single page
Comment 3 Darin Adler 2012-05-14 12:12:19 PDT
Comment on attachment 141764 [details]
Make tall lines split in the top leading so that the visible content fits on a single page

View in context: https://bugs.webkit.org/attachment.cgi?id=141764&action=review

Looks good.

> Source/WebCore/ChangeLog:10
> +        When a lineâs visible content fits on a page, but adding the top leading makes it taller than

Bad quote mark?
Comment 4 mitz 2012-05-14 12:15:12 PDT
(In reply to comment #3)
> > +        When a lineâs visible content fits on a page, but adding the top leading makes it taller than
> 
> Bad quote mark?

No, this is bug 75394. I wish I knew how to fix it.

Thanks for the review!
Comment 5 WebKit Review Bot 2012-05-14 12:43:31 PDT
Comment on attachment 141764 [details]
Make tall lines split in the top leading so that the visible content fits on a single page

Attachment 141764 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12684467

New failing tests:
fast/multicol/split-in-top-margin.html
Comment 6 WebKit Review Bot 2012-05-14 12:43:36 PDT
Created attachment 141770 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 7 mitz 2012-05-14 13:03:18 PDT
(In reply to comment #5)
> (From update of attachment 141764 [details])
> Attachment 141764 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/12684467
> 
> New failing tests:
> fast/multicol/split-in-top-margin.html

I am going to switch the test to using Ahem.
Comment 8 mitz 2012-05-14 13:04:00 PDT
Fixed in <http://trac.webkit.org/r116986>