Bug 86370 – [EFL] API for PageGroup visited links hash populating

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Mikhail Pozdnyakov]

An API that would let the client to populate PageGroup visited links hash from a persistent storage is needed in EFL port as a part of Global History Delegate functionality.
There should be also a notification mechanism so that WebCore can ask the client to fulfill the visited links hash.

[Mikhail Pozdnyakov]

Created attachment 141921 [details]
patch

[Gyuyoung Kim]

Comment on attachment 141921 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141921&action=review

> Source/WebKit/efl/ChangeLog:9
> +        persistent history storage to fill the visited links cache;

what is ; at cache; ?

> Source/WebKit/efl/ewk/ewk_view.cpp:1635
> +Eina_Bool ewk_view_add_visited_link(Evas_Object* ewkView, const char* visitedUrl)

Style nit : Is ewk_view_visited_link_add better?

[Gyuyoung Kim]

Comment on attachment 141921 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141921&action=review

Is this patch's test cases covered by Bug 82579 ?

> Source/WebKit/efl/ewk/ewk_view.h:1049
> +EAPI Eina_Bool  ewk_view_add_visited_link(Evas_Object *o,  const char *visited_url);

Do not two spaces in front of const keyword.

[Mikhail Pozdnyakov]

(In reply to comment #3)
> (From update of attachment 141921 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141921&action=review
> 
> Is this patch's test cases covered by Bug 82579 ?
> 
Yes. This bug is enabler for 82579 which is responsible for DRT part.

[Mikhail Pozdnyakov]

Created attachment 143541 [details]
patch v2 (fixed review comments)

[Mikhail Pozdnyakov]

(In reply to comment #2)
> (From update of attachment 141921 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141921&action=review
> 
> > Source/WebKit/efl/ChangeLog:9
> > +        persistent history storage to fill the visited links cache;
> 
> what is ; at cache; ?
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:1635
> > +Eina_Bool ewk_view_add_visited_link(Evas_Object* ewkView, const char* visitedUrl)
> 
> Style nit : Is ewk_view_visited_link_add better?

Fixed all above. Thanks for review.

[Gyuyoung Kim]

Looks good to me now.

[WebKit Review Bot]

Comment on attachment 143541 [details]
patch v2 (fixed review comments)

Clearing flags on attachment: 143541

Committed r118491: <http://trac.webkit.org/changeset/118491>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.