Bug 86370 - [EFL] API for PageGroup visited links hash populating
Summary: [EFL] API for PageGroup visited links hash populating
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks: 82579
  Show dependency tree / graph
 
Reported: 2012-05-14 07:20 PDT by Mikhail Pozdnyakov
Modified: 2012-05-25 01:00 PDT (History)
5 users (show)

See Also:

Attachments
patch (4.97 KB, patch)
2012-05-15 05:01 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
patch v2 (fixed review comments) (5.03 KB, patch)
2012-05-23 05:17 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-05-14 07:20:25 PDT 
An API that would let the client to populate PageGroup visited links hash from a persistent storage is needed in EFL port as a part of Global History Delegate functionality.
There should be also a notification mechanism so that WebCore can ask the client to fulfill the visited links hash.
Comment 1 Mikhail Pozdnyakov 2012-05-15 05:01:24 PDT 
Created attachment 141921 [details]
patch
Comment 2 Gyuyoung Kim 2012-05-22 20:03:27 PDT 
Comment on attachment 141921 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141921&action=review

> Source/WebKit/efl/ChangeLog:9
> +        persistent history storage to fill the visited links cache;

what is ; at cache; ?

> Source/WebKit/efl/ewk/ewk_view.cpp:1635
> +Eina_Bool ewk_view_add_visited_link(Evas_Object* ewkView, const char* visitedUrl)

Style nit : Is ewk_view_visited_link_add better?
Comment 3 Gyuyoung Kim 2012-05-22 20:06:37 PDT 
Comment on attachment 141921 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141921&action=review

Is this patch's test cases covered by Bug 82579 ?

> Source/WebKit/efl/ewk/ewk_view.h:1049
> +EAPI Eina_Bool  ewk_view_add_visited_link(Evas_Object *o,  const char *visited_url);

Do not two spaces in front of const keyword.
Comment 4 Mikhail Pozdnyakov 2012-05-23 04:32:06 PDT 
(In reply to comment #3)
> (From update of attachment 141921 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141921&action=review
> 
> Is this patch's test cases covered by Bug 82579 ?
> 
Yes. This bug is enabler for 82579 which is responsible for DRT part.
Comment 5 Mikhail Pozdnyakov 2012-05-23 05:17:22 PDT 
Created attachment 143541 [details]
patch v2 (fixed review comments)
Comment 6 Mikhail Pozdnyakov 2012-05-23 05:19:08 PDT 
(In reply to comment #2)
> (From update of attachment 141921 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141921&action=review
> 
> > Source/WebKit/efl/ChangeLog:9
> > +        persistent history storage to fill the visited links cache;
> 
> what is ; at cache; ?
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:1635
> > +Eina_Bool ewk_view_add_visited_link(Evas_Object* ewkView, const char* visitedUrl)
> 
> Style nit : Is ewk_view_visited_link_add better?

Fixed all above. Thanks for review.
Comment 7 Gyuyoung Kim 2012-05-23 19:45:53 PDT 
Looks good to me now.
Comment 8 WebKit Review Bot 2012-05-25 01:00:51 PDT 
Comment on attachment 143541 [details]
patch v2 (fixed review comments)

Clearing flags on attachment: 143541

Committed r118491: <http://trac.webkit.org/changeset/118491>
Comment 9 WebKit Review Bot 2012-05-25 01:00:59 PDT 
All reviewed patches have been landed.  Closing bug.