Bug 86352 - Making layout testcase: fast/table/empty-section-crash.html result platform independent
Summary: Making layout testcase: fast/table/empty-section-crash.html result platform i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-14 03:56 PDT by Arpita Bahuguna
Modified: 2012-05-15 06:57 PDT (History)
3 users (show)

See Also:

Attachments
Patch (13.08 KB, patch)
2012-05-14 04:02 PDT, Arpita Bahuguna 		no flags Details | Formatted Diff | Diff
Patch (13.54 KB, patch)
2012-05-14 04:50 PDT, Arpita Bahuguna 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arpita Bahuguna 2012-05-14 03:56:31 PDT 
Making fast/table/empty-section-crash.html as dumpAsText().

Requires removal of existing .png and renderTreeDump txt files from their respective platforms.
Comment 1 Arpita Bahuguna 2012-05-14 04:02:07 PDT 
Created attachment 141686 [details]
Patch
Comment 2 Antti Koivisto 2012-05-14 04:08:29 PDT 
Comment on attachment 141686 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141686&action=review

r=me

> LayoutTests/ChangeLog:6
> +        Making layout testcase: fast/table/empty-section-crash.html result platform independent
> +        https://bugs.webkit.org/show_bug.cgi?id=86352
> +
> +        Reviewed by NOBODY (OOPS!).

You should mention that you will be adding a reftest that covers rendering.
Comment 3 Arpita Bahuguna 2012-05-14 04:13:47 PDT 
Thanks Antti. 

Shall be adding a reftest for this issue soon.
Comment 4 Arpita Bahuguna 2012-05-14 04:50:04 PDT 
Created attachment 141693 [details]
Patch
Comment 5 Arpita Bahuguna 2012-05-14 06:59:42 PDT 
Comment on attachment 141693 [details]
Patch

Thanks for the review Antti.
Comment 6 WebKit Review Bot 2012-05-15 06:57:15 PDT 
Comment on attachment 141693 [details]
Patch

Clearing flags on attachment: 141693

Committed r117062: <http://trac.webkit.org/changeset/117062>
Comment 7 WebKit Review Bot 2012-05-15 06:57:22 PDT 
All reviewed patches have been landed.  Closing bug.