We need more tests!
Created attachment 143293 [details] Patch
Comment on attachment 143293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143293&action=review Looks good to me with a few of comments. > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml:88 > + messageSpy.clear() The init() function should be clearing this for us already. > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml:97 > + webView.resultReceived() Could we get rid of resultReceived and make the spy look at lastResultChanged signal? > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml:98 > + }); Try to be consistent about semicolons.
Created attachment 143531 [details] Patch
Comment on attachment 143531 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143531&action=review > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml:132 > + compare(webView.lastResult, 1337) float?
Committed r118163: <http://trac.webkit.org/changeset/118163>