Bug 86351 - [Qt] Missing tests for the evaluateJavaScript API
Summary: [Qt] Missing tests for the evaluateJavaScript API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexander Færøy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-14 03:55 PDT by Alexander Færøy
Modified: 2012-05-23 05:14 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.98 KB, patch)
2012-05-22 06:27 PDT, Alexander Færøy
no flags Details | Formatted Diff | Diff
Patch (5.66 KB, patch)
2012-05-23 04:45 PDT, Alexander Færøy
kenneth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Færøy 2012-05-14 03:55:56 PDT
We need more tests!
Comment 1 Alexander Færøy 2012-05-22 06:27:12 PDT
Created attachment 143293 [details]
Patch
Comment 2 Caio Marcelo de Oliveira Filho 2012-05-22 07:48:05 PDT
Comment on attachment 143293 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143293&action=review

Looks good to me with a few of comments.

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml:88
> +            messageSpy.clear()

The init() function should be clearing this for us already.

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml:97
> +                    webView.resultReceived()

Could we get rid of resultReceived and make the spy look at lastResultChanged signal?

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml:98
> +                });

Try to be consistent about semicolons.
Comment 3 Alexander Færøy 2012-05-23 04:45:54 PDT
Created attachment 143531 [details]
Patch
Comment 4 Kenneth Rohde Christiansen 2012-05-23 04:54:56 PDT
Comment on attachment 143531 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143531&action=review

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml:132
> +            compare(webView.lastResult, 1337)

float?
Comment 5 Alexander Færøy 2012-05-23 05:14:48 PDT
Committed r118163: <http://trac.webkit.org/changeset/118163>